Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to the Alpaka integration in CMSSW [14.0.x] #43879

Merged
merged 25 commits into from
Feb 13, 2024

Commits on Feb 5, 2024

  1. Skip invalid or corrupted ROCs

    Make the Alpaka implementation of the pixel unpacker skip spurious ROCs,
    similar to the legacy and CUDA versions of the unpacker, and store the
    invalid ROC number error (errorType=36).
    
    Disable printf statements at compile time.
    
    Use named constants instead of magic numbers.
    fwyzard committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    28bcb55 View commit details
    Browse the repository at this point in the history
  2. Add check on the ROC range

    fwyzard committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    e142ccc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a2c7a27 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2b5e6f6 View commit details
    Browse the repository at this point in the history
  5. Rewrite the pixel clustering code

    Rewrite loops using cms::alpakatools::independent_groups(acc, ...) and
    independent_group_elements(acc, ...).
    
    Rename variables and improve comments to help readability.
    fwyzard committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    937f0da View commit details
    Browse the repository at this point in the history
  6. Rewrite the pixel charge cut code

    Rewrite loops using cms::alpakatools::independent_groups(acc, ...) and
    independent_group_elements(acc, ...).
    
    General clean up.
    fwyzard committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    571c91f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    357cfba View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8f6ecae View commit details
    Browse the repository at this point in the history
  9. Fix check for invalid pixel digis

    AdrianoDee authored and fwyzard committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    c073269 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1f91765 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c116e10 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Renumber the ECAL-only alpaka workflow to .412

    Renumber the ECAL-only alpaka workflow from ##.411 to ##.412, for
    consistency with the old gpu workflows (##.512) and the other alpaka
    workflows.
    fwyzard committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f3592ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e16a1a8 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Add alpaka workflows to the GPU relvals

    Add pixel-only and ECAL-only alpaka workflows to the set of GPU relvals.
    fwyzard committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    0851cc3 View commit details
    Browse the repository at this point in the history
  2. Add a protection for quasi-empty events

    Do not call the fishbone for quasi-empty events, with pixel hits only in
    the innermost layer.
    
    Clean up the implementation of the fishbone.
    
    Extend TrackingRecHits collections for testing and their unit tests.
    
    Co-authored-by: Adriano Di Florio <adriano.di.florio@cern.ch>
    fwyzard and AdrianoDee committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    9369dbc View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Configuration menu
    Copy the full SHA
    63902cb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff7e930 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bd9fe2d View commit details
    Browse the repository at this point in the history
  4. Rewrite the uniform element kernel loops

    Generalise elements_with_stride, blocks_with_stride and elements_in_block to
    work on any single dimension, and rename them to uniform_elements_along,
    uniform_groups_along and uniform_group_elements_along.
    
    Introduce uniform_elements[_x|_y|_z], uniform_groups[_x|_y|_z] and
    uniform_group_elements[_x|_y|_z] as specialisations of uniform_elements_along,
    uniform_groups_along and uniform_group_elements_along.
    
    Reintrouce elements_with_stride, blocks_with_stride, elements_in_block as
    legacy names for uniform_elements, uniform_groups, and uniform_group_elements.
    
    Rename elements_with_stride_nd to uniform_elements_nd, and reintroduce
    elements_with_stride_nd as a legacy name for uniform_elements_nd.
    
    Update the unit tests accordingly.
    fwyzard committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    b3de2a3 View commit details
    Browse the repository at this point in the history
  5. Rewrite the independent element kernel loops

    Generalise independent_groups and independent_group_elements to work on any single
    dimension, and rename them to independent_groups_along and independent_group_elements_along.
    
    Introduce independent_groups[_x|_y|_z] and independent_group_elements[_x|_y|_z]
    as specialisations of independent_groups_along and independent_group_elements_along.
    fwyzard committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    5a87cef View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    70371a8 View commit details
    Browse the repository at this point in the history
  7. Rewrite pixel clustering and rechits using alpakatools utilities

    Rewrite the alpaka pixel clustering and rechit-building code using the uniform
    and independent kernel utilities from cms::alpakatools.
    fwyzard committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    2d01108 View commit details
    Browse the repository at this point in the history
  8. Rewrite pixel seeding using alpakatools utilities

    Rewrite the alpaka pixel seeding code using the uniform and independent kernel
    utilities from cms::alpakatools.
    fwyzard committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    1bd5d4a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    008ca51 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c7d3641 View commit details
    Browse the repository at this point in the history