Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update XangleBetaStarFilter with NewLHCInfo #43854

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

michael-pitt
Copy link
Contributor

@michael-pitt michael-pitt commented Feb 3, 2024

PR description:

The XangleBetaStarFilter will be using the recently introduced new LHCInfo (#42515), and it is a part of the post-processing calibration tools used by Proton Object.

PR validation:

The new filter was tested with
cmsRun CondTools/RunInfo/test/xangleBetaStarFilter_test_cfg.py
using CMSSW_14_0_0_pre3

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43854/38693

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2024

A new Pull Request was created by @michael-pitt (Michael Pitt) for master.

It involves the following packages:

  • CondTools/RunInfo (db)

@francescobrivio, @cmsbuild, @consuegs, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@yuanchao, @mmusich, @rsreds, @PonIlya this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_14_1_X Feb 6, 2024
@perrotta
Copy link
Contributor

perrotta commented Feb 6, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e64966/37249/summary.html
COMMIT: 175d85b
CMSSW: CMSSW_14_0_X_2024-02-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43854/37249/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Feb 8, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 42eeffe into cms-sw:master Feb 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants