-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Era_Run3_2024
, Era_Run3_2025
, Tier0 reco scenario for 2024, and change default era in PyReleaseValidation
#43761
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
29 changes: 29 additions & 0 deletions
29
Configuration/DataProcessing/python/Impl/ppEra_Run3_2024.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
#!/usr/bin/env python3 | ||
""" | ||
_ppEra_Run3_2024_ | ||
Scenario supporting proton collisions for 2024 | ||
""" | ||
|
||
import os | ||
import sys | ||
|
||
from Configuration.DataProcessing.Reco import Reco | ||
import FWCore.ParameterSet.Config as cms | ||
from Configuration.Eras.Era_Run3_2024_cff import Run3_2024 | ||
|
||
from Configuration.DataProcessing.Impl.pp import pp | ||
|
||
class ppEra_Run3_2024(pp): | ||
def __init__(self): | ||
pp.__init__(self) | ||
self.recoSeq='' | ||
self.cbSc='pp' | ||
self.eras=Run3_2024 | ||
self.promptCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_2024' ] | ||
self.expressCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_2024' ] | ||
self.visCustoms += [ 'Configuration/DataProcessing/RecoTLR.customisePostEra_Run3_2024' ] | ||
""" | ||
_ppEra_Run3_2024_ | ||
Implement configuration building for data processing for proton | ||
collision data taking for Run3_2024 | ||
""" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
from Configuration.Eras.Era_Run3_cff import Run3 | ||
|
||
Run3_2024 = cms.ModifierChain(Run3) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
from Configuration.Eras.Era_Run3_2024_cff import Run3_2024 | ||
|
||
Run3_2025 = cms.ModifierChain(Run3_2024) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not totally sure to understand what's the intent here, but this line is necessary to avoid having runtime matrix failures. I am wondering if instead of excluding explicitly every "customization" on top of
Run3
one should just match exactlyRun3
and be done with it (but then I don't understand the purpose of this class).Perhaps @cms-sw/pdmv-l2 or @cms-sw/upgrade-l2 can clarify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srimanob do you have any idea of the usage of this
UpgradeWorkflow_DDDDB
. Sincerely I don't know/remember.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to use DDD from DB, see
https://github.com/cms-sw/cmssw/blob/master/Configuration/AlCa/python/autoCondModifiers.py#L34-L75
It was invented when we move DDD to DD4hep, but we wanted to keep DDD around for 2022. That is why we have
not in
in several places to avoid failure due to non-existing era. I agree with @mmusich, we can just match exactly.