[HGCAL trigger] Configurations fixes and updates #43706

jbsauvan · 2024-01-12T13:53:20Z

PR description:

Configurations fixes and updates
In particular to work with V16 geometry

Associated internal PRs and reviews:

PR validation:

Tested D86, D92, D94 workflows

runTheMatrix.py -w upgrade -l 20034.0 --maxSteps=2 & # D86
runTheMatrix.py -w upgrade -l 22434.0 --maxSteps=2 & # D92
runTheMatrix.py -w upgrade -l 23234.0 --maxSteps=2 & # D94

cmsbuild · 2024-01-12T13:53:48Z

cms-bot internal usage

cmsbuild · 2024-01-12T13:59:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43706/38395

This PR adds an extra 28KB to repository

cmsbuild · 2024-01-12T13:59:47Z

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

L1Trigger/L1THGCal (upgrade, l1)
L1Trigger/L1THGCalUtilities (upgrade, l1)

@subirsarkar, @epalencia, @cmsbuild, @aloeliger, @srimanob can you please review it and eventually sign? Thanks.
@amarini, @lgray, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

aloeliger · 2024-01-17T10:18:08Z

please test

cmsbuild · 2024-01-17T13:03:55Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b33ee/36881/summary.html
COMMIT: 19e4052
CMSSW: CMSSW_14_0_X_2024-01-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43706/36881/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 5 lines to the logs
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3247526
DQMHistoTests: Total failures: 115
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3247389
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 200 log files, 161 edm output root files, 48 DQM output files
TriggerResults: found differences in 2 / 46 workflows

aloeliger · 2024-01-22T10:39:47Z

@pallabidas & @artlbv Just bringing this to your attention, pallabi because this is HGCal inputs to calo, and artur because that means it may be physics affecting.

aloeliger · 2024-01-26T10:39:39Z

+l1

artlbv · 2024-01-26T10:43:26Z

@jbsauvan does this actually change anything performance-wise in the HGCAL TPs? If yes, could you link to some slides etc showing this? merci!

jbsauvan · 2024-01-26T11:06:21Z

@jbsauvan does this actually change anything performance-wise in the HGCAL TPs? If yes, could you link to some slides etc showing this? merci!

Hi @artlbv
It has some impact on the TPs energy in V16+ eras, coming from a fix in the layer weights used to calibrate trigger cell energies.
The level of the impact can be seen in this comment here

cmsbuild · 2024-02-06T10:10:54Z

Milestone for this pull request has been moved to CMSSW_14_1_X. Please open a backport if it should also go in to CMSSW_14_0_X.

jbsauvan · 2024-02-08T12:24:17Z

I indeed did a rebase on 14_1_X (from 14_0_X) before squashing.

antoniovilela · 2024-02-08T12:28:04Z

@antoniovilela , no ideally bot should not have reset the signatures but looks like it was rebase + squash so that is why bot had reset the sign. rebase changes the parent e.g. previously https://github.com/cms-sw/cmssw/commits/19e40529a474eb3f839582d6d1b38ab176849ca1/ was the history of this PR ( i.e parent was f5cbbf1 ) and now https://github.com/cms-sw/cmssw/commits/d87e63341a18735ecb4a5830aa23939b8bb588e4/ is based on 93f14ae. In such case bot will see differences and will reset all the signs.

Ok, many thanks for checking.

antoniovilela · 2024-02-08T12:33:29Z

I indeed did a rebase on 14_1_X (from 14_0_X) before squashing.

Ok, let's get the L2 signatures again and then merge.
@cms-sw/l1-l2 @cms-sw/upgrade-l2

artlbv · 2024-02-08T12:42:51Z

thanks for the clarifications @jbsauvan !

So before this PR the trigger layers definition and layer calibration were incorrect for geometries >=V16. Which is fixed here.

@srimanob if i understand correctly, since the 125X MC campaign the geometry was at least D88 -> C17 -> V16.
Thus is my understanding correct, that since 125X the HGCAL trigger layer/calibrations were off in all MC campaigns?

Also @EmyrClement FYI I assume we can expect some impacts down the line?

smuzaffar · 2024-02-08T15:32:39Z

@antoniovilela , @iarspider and I believe bot should not have reset sign in this case. Even though PR was rebased but there were no changes difference between original PR and squashed PR. In order to test why bot resetted signs I am manually editing #43706 (comment) to see what bot did

antoniovilela · 2024-02-08T15:43:20Z

@antoniovilela , @iarspider and I believe bot should not have reset sign in this case. Even though PR was rebased but there were no changes difference between original PR and squashed PR. In order to test why bot resetted signs I am manually editing #43706 (comment) to see what bot did

Ok, many thanks.

cmsbuild · 2024-02-08T16:06:21Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2024-02-08T16:07:19Z

@antoniovilela , there was a bug and bot was not proerly reading the previously cached information. This is fixed now and bot has properly kept the signatures

cmsbuild · 2024-02-08T19:09:38Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b33ee/37308/summary.html
COMMIT: d87e633
CMSSW: CMSSW_14_1_X_2024-02-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43706/37308/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 106 lines to the logs
Reco comparison results: 60 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3346157
DQMHistoTests: Total failures: 137
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3345998
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 165 edm output root files, 49 DQM output files
TriggerResults: found differences in 4 / 47 workflows

antoniovilela · 2024-02-08T21:50:54Z

@antoniovilela , there was a bug and bot was not proerly reading the previously cached information. This is fixed now and bot has properly kept the signatures

Great, thanks!

antoniovilela · 2024-02-08T21:51:52Z

+1

cmsbuild · 2024-02-09T02:35:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3b33ee/37315/summary.html
COMMIT: d87e633
CMSSW: CMSSW_14_1_X_2024-02-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43706/37315/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 102 lines to the logs
Reco comparison results: 76 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3346157
DQMHistoTests: Total failures: 1320
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3344815
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 205 log files, 165 edm output root files, 49 DQM output files
TriggerResults: found differences in 4 / 47 workflows

cmsbuild added this to the CMSSW_14_0_X milestone Jan 12, 2024

cmsbuild added l1-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Jan 12, 2024

jbsauvan mentioned this pull request Jan 12, 2024

Integration of V16 configuration fixes and updates hgc-tpg/cmssw#99

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 12, 2024

cmsbuild added tests-started and removed tests-pending labels Jan 17, 2024

cmsbuild added tests-approved and removed tests-started labels Jan 17, 2024

cmsbuild added l1-approved and removed l1-pending labels Jan 26, 2024

cmsbuild modified the milestones: CMSSW_14_0_X, CMSSW_14_1_X Feb 6, 2024

cmsbuild added l1-approved fully-signed tests-started upgrade-approved and removed l1-pending pending-signatures tests-pending upgrade-pending labels Feb 8, 2024

smuzaffar mentioned this pull request Feb 8, 2024

Throw exception if TFile::Open returns nullptr #43920

Merged

cmsbuild added tests-approved and removed tests-started labels Feb 8, 2024

cmsbuild added orp-approved and removed orp-pending labels Feb 8, 2024

cmsbuild merged commit 4a6d7e8 into cms-sw:master Feb 8, 2024
12 checks passed

cmsbuild added tests-started and removed tests-approved labels Feb 8, 2024

cmsbuild added tests-approved and removed tests-started labels Feb 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HGCAL trigger] Configurations fixes and updates #43706

[HGCAL trigger] Configurations fixes and updates #43706

jbsauvan commented Jan 12, 2024 •

edited by smuzaffar

Loading

cmsbuild commented Jan 12, 2024 •

edited

Loading

cmsbuild commented Jan 12, 2024

cmsbuild commented Jan 12, 2024

aloeliger commented Jan 17, 2024

cmsbuild commented Jan 17, 2024

aloeliger commented Jan 22, 2024 •

edited

Loading

aloeliger commented Jan 26, 2024

artlbv commented Jan 26, 2024

jbsauvan commented Jan 26, 2024

cmsbuild commented Feb 6, 2024

jbsauvan commented Feb 8, 2024

antoniovilela commented Feb 8, 2024

antoniovilela commented Feb 8, 2024 •

edited

Loading

artlbv commented Feb 8, 2024

smuzaffar commented Feb 8, 2024 •

edited

Loading

antoniovilela commented Feb 8, 2024 •

edited by smuzaffar

Loading

cmsbuild commented Feb 8, 2024

smuzaffar commented Feb 8, 2024

cmsbuild commented Feb 8, 2024

antoniovilela commented Feb 8, 2024

antoniovilela commented Feb 8, 2024

cmsbuild commented Feb 9, 2024

[HGCAL trigger] Configurations fixes and updates #43706

[HGCAL trigger] Configurations fixes and updates #43706

Conversation

jbsauvan commented Jan 12, 2024 • edited by smuzaffar Loading

PR description:

PR validation:

cmsbuild commented Jan 12, 2024 • edited Loading

cmsbuild commented Jan 12, 2024

cmsbuild commented Jan 12, 2024

aloeliger commented Jan 17, 2024

cmsbuild commented Jan 17, 2024

Comparison Summary

aloeliger commented Jan 22, 2024 • edited Loading

aloeliger commented Jan 26, 2024

artlbv commented Jan 26, 2024

jbsauvan commented Jan 26, 2024

cmsbuild commented Feb 6, 2024

jbsauvan commented Feb 8, 2024

antoniovilela commented Feb 8, 2024

antoniovilela commented Feb 8, 2024 • edited Loading

artlbv commented Feb 8, 2024

smuzaffar commented Feb 8, 2024 • edited Loading

antoniovilela commented Feb 8, 2024 • edited by smuzaffar Loading

cmsbuild commented Feb 8, 2024

smuzaffar commented Feb 8, 2024

cmsbuild commented Feb 8, 2024

Comparison Summary

antoniovilela commented Feb 8, 2024

antoniovilela commented Feb 8, 2024

cmsbuild commented Feb 9, 2024

Comparison Summary

jbsauvan commented Jan 12, 2024 •

edited by smuzaffar

Loading

cmsbuild commented Jan 12, 2024 •

edited

Loading

aloeliger commented Jan 22, 2024 •

edited

Loading

antoniovilela commented Feb 8, 2024 •

edited

Loading

smuzaffar commented Feb 8, 2024 •

edited

Loading

antoniovilela commented Feb 8, 2024 •

edited by smuzaffar

Loading