-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-HGX350A Resolve the scenario for V18 version of HGCal Geometry #43661
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43661/38326
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43661/38327
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@miquork, @srimanob, @Dr15Jones, @AdrianoDee, @davidlange6, @cmsbuild, @rappoccio, @civanch, @makortel, @bsunanda, @mdhildreth, @antoniovilela, @sunilUIET, @subirsarkar, @fabiocos can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02cede/36714/summary.html Comparison SummarySummary:
|
test parameters:
|
@cmsbuild please test |
+1 |
@sunilUIET Could you approve this? |
+pdmv |
@rappoccio @antoniovilela Please merge this PR |
@rappoccio @antoniovilela Please merge this PR. we are waiting for the next PR |
@rappoccio @antoniovilela Please merge this PR. We are waiting for this new IB to declare a new workflow |
1 similar comment
@rappoccio @antoniovilela Please merge this PR. We are waiting for this new IB to declare a new workflow |
type bug fix |
Please merge - otherwise V18 is meaningless |
Bug fix |
Type Bug-Fix |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Resolve the scenario for V18 version of HGCal Geometry
PR validation:
Use the runTheMatrix test workflows
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special