Making ECAL detector based isolation more robust against noise

[swagata87]

PR description:

Using ECAL PF rechit thresholds for ECAL detector based isolation to make it more robust against noise. With this change, the distributions of ECAL isolation variables (cone size 0.3 and 0.4) should shift a bit towards lower values. The shift sould be more prominent in endcaps.

PR validation:

Checked with run3 workflows.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43535/38117

• This PR adds an extra 56KB to repository

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

• DQMOffline/Trigger (dqm)
• RecoEgamma/EgammaElectronAlgos (reconstruction)
• RecoEgamma/EgammaIsolationAlgos (reconstruction)
• RecoEgamma/EgammaPhotonProducers (reconstruction)
• RecoEgamma/PhotonIdentification (reconstruction)

@antoniovagnerini, @cmsbuild, @rvenditti, @mandrenguyen, @syuvivida, @jfernan2, @tjavaid, @nothingface0 can you please review it and eventually sign? Thanks.
@ram1123, @valsdav, @Fedespring, @mtosi, @afiqaize, @sobhatta, @lgray, @a-kapoor, @cericeci, @missirol, @sameasy, @Prasant1993, @jhgoh, @HuguesBrun, @Sam-Harper, @ReyerBand, @argiro, @rociovilar, @wang0jin, @varuns23, @thomreis, @jainshilpi, @rovere, @rchatter, @trocino this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

assign ecal-dpg

[cmsbuild]

New categories assigned: ecal-dpg

@wang0jin,@thomreis you have been requested to review this Pull request/Issue and eventually sign? Thanks

[swagata87]

type egamma

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43535/38124

• This PR adds an extra 56KB to repository

[cmsbuild]

Pull request #43535 was updated. @thomreis, @jfernan2, @antoniovagnerini, @tjavaid, @mandrenguyen, @wang0jin, @rvenditti, @cmsbuild, @nothingface0, @syuvivida can you please check and sign again.

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35e690/36409/summary.html
COMMIT: 1b105c1
CMSSW: CMSSW_14_0_X_2023-12-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43535/36409/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 266 lines from the logs
• Reco comparison results: 1779 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3430794
• DQMHistoTests: Total failures: 1070
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3429702
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[RSalvatico]

+egamma-pog

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35e690/36497/summary.html
COMMIT: c93af8d
CMSSW: CMSSW_14_0_X_2023-12-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43535/36497/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 89 lines to the logs
• Reco comparison results: 1781 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3429858
• DQMHistoTests: Total failures: 998
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3428838
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[swagata87]

@cms-sw/dqm-l2 do you have any comment?

[tjavaid]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35e690/36625/summary.html
COMMIT: c93af8d
CMSSW: CMSSW_14_0_X_2023-12-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43535/36625/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 105 lines to the logs
• Reco comparison results: 1783 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 999
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3246256
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1