[UBSAN] Fix errors in RecoVertex/PrimaryVertexProducer and PhysicsTools/PatAlgos

[iarspider]

Fixes #43341 as suggested by @slava77 in #43341 (comment) and @makortel in #43341 (comment).

Validation: bot tests

[iarspider]

please test workflow 138.3 for CMSSW_14_0_UBSAN_X

(This RelVal will most likely segfault due to #37362, but the runtime error should be gone)

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43414/37918

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43414/37918/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43414/37918/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43414/37920

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• PhysicsTools/PatAlgos (reconstruction, xpog)
• RecoVertex/PrimaryVertexProducer (reconstruction)

@simonepigazzini, @jfernan2, @vlimant, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks.
@mtosi, @Senphy, @JyothsnaKomaragiri, @schoef, @ahinzmann, @rovere, @demuller, @gkasieczka, @mmarionncern, @mbluj, @gouskos, @AlexDeMoor, @nhanvtran, @Ming-Yan, @jdolen, @missirol, @gpetruc, @JanFSchulte, @AnnikaStein, @mariadalfonso, @hatakeyamak, @dgulhan, @seemasharmafnal, @VourMa, @emilbols, @GiacomoSguazzoni, @andrzejnovak, @jdamgov, @azotz, @rappoccio, @mmusich, @VinInn this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test workflow 138.3 for CMSSW_14_0_UBSAN_X

[iarspider]

please test workflow 138.3

[slava77]

@iarspider
you may want to update the PR description and perhaps the title as well to mention the fix in PhysicsTools/PatAlgos, which has nothing to do with RecoVertex.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbd6a5/36110/summary.html
COMMIT: e641545
CMSSW: CMSSW_14_0_X_2023-11-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43414/36110/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @iarspider Fix usage of deprecated methods returning TIterator (replace with range loops or begin/end) #43373
• @bsunanda Run3-alca248X Get rid of some unnecessary include and a small improvement of a macro #43389
• @fabiocos MTD Geometry: Optimize speed of MTD ideal geometry dump and improve verbosity #43388

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbd6a5/36110/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbd6a5/36110/git-merge-result

Comparison Summary

Summary:

• You potentially added 266 lines to the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3434200
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3434176
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 218 log files, 170 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbd6a5/36109/summary.html
COMMIT: e641545
CMSSW: CMSSW_14_0_UBSAN_X_2023-11-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43414/36109/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @iarspider Fix usage of deprecated methods returning TIterator (replace with range loops or begin/end) #43373
• @bsunanda Run3-alca248X Get rid of some unnecessary include and a small improvement of a macro #43389
• @fabiocos MTD Geometry: Optimize speed of MTD ideal geometry dump and improve verbosity #43388

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbd6a5/36109/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbd6a5/36109/git-merge-result

[iarspider]

@iarspider you may want to update the PR description and perhaps the title as well to mention the fix in PhysicsTools/PatAlgos, which has nothing to do with RecoVertex.

I have updated the title and description.

[jfernan2]

+1

[vlimant]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1