[DT Emulator] First cleaned version AMv2 with SL2

[jfernan2]

PR description:

Forward port of cms-l1t-offline#1166

This PR integrates the new version (v2) of the Analytical Method for the Phase-2 DT Emulator.

It has been presented in the DT Upgrade (trigger primitives and test systems)[1] and in the Level-1 Muon DPG meeting [2].

Needs data files from PR cms-data/L1Trigger-DTTriggerPhase2#3

Credits of the code to @jaimeleonh [3], SL2 emulation addition from [4] and theta coordinates fix from @mcepeda

PR validation:

The software goes hand by hand with the developments being implemented in the firmware. In links [1] and [2] are presented performance results with the new AMv2 algorithm :

• In simulation with the emulator

• Comparing emulator and firmware in the laboratory

• Similar (or even improved) performance w.r.t. previous AM version (v1, already in CMSSW)

[1] https://indico.cern.ch/event/1262475/contributions/5308462/attachments/2607937/4505149/230309_NewAM_DTUpgrade_JLH.pdf
[2] https://indico.cern.ch/event/1263362/contributions/5305755/attachments/2607489/4504221/230308_NewAM_L1MuonDPG_JLH.pdf

[3] https://github.com/jaimeleonh/cmssw/tree/AM_12_4_2_new_fitter
[4] https://github.com/jfernan2/cmssw/tree/AM_12_4_2_new_fitter_withThetas

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport needed

[cmsbuild]

@jfernan2, CMSSW_14_0_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43390/37887

• This PR adds an extra 80KB to repository

[cmsbuild]

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

• L1Trigger/DTTriggerPhase2 (l1, upgrade)

@srimanob, @aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@battibass, @missirol, @Martin-Grunewald, @JanFSchulte this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test with cms-data/L1Trigger-DTTriggerPhase2#3

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e133a0/36062/summary.html
COMMIT: 38d5507
CMSSW: CMSSW_14_0_X_2023-11-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43390/36062/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[aloeliger]

@jfernan2 There is an error with an unused variable:

L1Trigger/DTTriggerPhase2/src/MuonPathAnalyzerInChamber.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-24-2300/src/L1Trigger/DTTriggerPhase2/src/MuonPathAnalyzerInChamber.cc:720:7: warning: variable 'validHits' set but not used [-Wunused-but-set-variable]

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43390/37987

• This PR adds an extra 136KB to repository

[cmsbuild]

Pull request #43390 was updated. @aloeliger, @srimanob, @epalencia can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e133a0/36189/summary.html
COMMIT: 0efbb6b
CMSSW: CMSSW_14_0_X_2023-11-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43390/36189/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw [LTO] Improve link time by using multiple process for linking cmsdist#8840
• @cms-sw Update tag for RecoTracker-FinalTrackSelectors to V01-05-00 cmsdist#8847

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e133a0/36189/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e133a0/36189/git-merge-result

Comparison Summary

Summary:

• You potentially added 4348 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 6
• DQMHistoTests: Total histograms compared: 21823
• DQMHistoTests: Total failures: 36
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 21787
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 5 files compared)
• Checked 134 log files, 68 edm output root files, 6 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

• Already reviewed as part of [DT Emulator] First cleaned version AMv2 with SL2 cms-l1t-offline/cmssw#1166

[srimanob]

I just copy the static log check which relate to L1Trigger/DTTriggerPhase2 here. So you can check and implement in the next PR. I don't think they directly relate to this PR.

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/GlobalCoordsObtainer.cc:222:3: warning: Value stored to 'x_msb' is never read [deadcode.DeadStores]
  222 |   x_msb = from_two_comp(x_msb, PHI_LUT_ADDR_WIDTH);
      |   ^       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/GlobalCoordsObtainer.cc:225:3: warning: Value stored to 'tanpsi_msb' is never read [deadcode.DeadStores]
  225 |   tanpsi_msb = from_two_comp(tanpsi_msb, PHIB_LUT_ADDR_WIDTH);
      |   ^            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/MuonPathAssociator.cc:592:15: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
  592 |           if (useFitSL3[sl3])
      |               ^~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/MuonPathAssociator.cc:844:19: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
  844 |               if (useFitSL1[sl1])
      |                   ^~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/MuonPathAssociator.cc:905:19: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
  905 |               if (useFitSL3[sl3])
      |                   ^~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/MuonPathAssociator.cc:1011:9: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
 1011 |     if (!useFit[i])
      |         ^~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/MuonPathAssociator.cc:1016:11: warning: Branch condition evaluates to a garbage value [core.uninitialized.Branch]
 1016 |       if (!useFit[j])

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-29-2300/src/L1Trigger/DTTriggerPhase2/src/MuonPathAnalyzerInChamber.cc:245:9: warning: cms.NonFiniteMath [cms.NonFiniteMath]
  245 |     if (isnan(jm_x))
      |         ^
1 warning generated.

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[jfernan2]

Thanks @srimanob
Indeed it is not related to this PR but I will implement a fix for that in the next iteration

[rappoccio]

+1