Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring of tau decay products in NanoDQM #43382

Merged

Conversation

Ksavva1021
Copy link
Contributor

PR description:

This PR builds on top of #42987, such that the tau decay products can be monitored by NanoDQM.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backports for this PR are planned for CMSSW versions 13_2_X, 13_3_X.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43382/37870

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Ksavva1021 (Klitos Savva) for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@vlimant, @cmsbuild, @simonepigazzini can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Ksavva1021
Copy link
Contributor Author

Adding @mbluj as a watcher

@vlimant
Copy link
Contributor

vlimant commented Dec 1, 2023

enable nano

@vlimant
Copy link
Contributor

vlimant commented Dec 1, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f934ab/36244/summary.html
COMMIT: 10a7120
CMSSW: CMSSW_14_0_X_2023-11-30-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43382/36244/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 277 lines from the logs
  • Reco comparison results: 30 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3370032
  • DQMHistoTests: Total failures: 1190
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3368820
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 14.959999999999997 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 1.360 KiB Physics/NanoAODDQM
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16335
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16335
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 19.039999999999996 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 1.360 KiB Physics/NanoAODDQM
  • Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.539 2.539 0.000 ( +0.0% ) 5.26 5.28 -0.4% 2.148 2.146
2500.001 2.686 2.686 0.000 ( +0.0% ) 4.77 4.71 +1.3% 2.577 2.586
2500.002 2.622 2.622 0.000 ( +0.0% ) 4.94 4.89 +1.0% 2.561 2.569
2500.01 1.310 1.310 0.000 ( +0.0% ) 9.83 9.81 +0.1% 2.276 2.271
2500.011 1.726 1.726 0.000 ( +0.0% ) 5.32 5.31 +0.3% 2.461 2.468
2500.012 1.572 1.572 0.000 ( +0.0% ) 7.59 7.66 -1.0% 2.369 2.372
2500.1 2.190 2.190 0.000 ( +0.0% ) 5.24 5.36 -2.4% 2.007 2.011
2500.2 2.301 2.301 0.000 ( +0.0% ) 6.15 6.14 +0.2% 1.923 1.920
2500.21 1.177 1.177 0.000 ( +0.0% ) 4.42 4.40 +0.5% 2.230 2.223
2500.211 1.540 1.540 0.000 ( +0.0% ) 3.85 3.83 +0.6% 2.307 2.304
2500.3 2.057 2.057 0.000 ( +0.0% ) 13.02 13.18 -1.3% 1.906 1.903
2500.31 1.253 1.253 0.000 ( +0.0% ) 20.37 20.89 -2.5% 2.308 2.308
2500.311 1.639 1.639 0.000 ( +0.0% ) 14.17 14.45 -1.9% 2.391 2.382
2500.312 7.025 7.025 0.000 ( +0.0% ) 1.44 1.35 +7.0% 1.649 1.648
2500.313 1.471 1.471 0.000 ( +0.0% ) 6.46 7.04 -8.2% 0.985 0.984
2500.4 2.057 2.057 0.000 ( +0.0% ) 12.93 12.92 +0.1% 1.910 1.911
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.20 1.40 -14.2% 1.296 1.298

@vlimant
Copy link
Contributor

vlimant commented Dec 4, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5295a61 into cms-sw:master Dec 4, 2023
13 checks passed
@vlimant
Copy link
Contributor

vlimant commented May 6, 2024

type tau

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2024

cms-bot internal usage

@cmsbuild cmsbuild added the tau label May 6, 2024
@mbluj mbluj deleted the CMSSW_14_0_X_tau-pog_tauProdsInNano_DQM branch September 13, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants