[MkFit] Remove commented-out code, follow up to #43146

[osschar]

Remove the commented-out new implementation of prop-to-R that separates parameter and error propagation (as is done in prop-to-plane).

This is a follow-up PR to #43146 where this commit has been lost during the final rebase.

There are no active code changes, just removal of commented out parts.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43356/37828

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTracker/MkFitCore/src/PropagationMPlex.cc modified in PR(s): [mkFit] Apply material effects after error propagation #43350

[cmsbuild]

A new Pull Request was created by @osschar (Matevž Tadel) for master.

It involves the following packages:

• RecoTracker/MkFitCore (reconstruction)

@jfernan2, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks.
@mtosi, @dgulhan, @mmusich, @gpetruc, @JanFSchulte, @felicepantaleo, @missirol, @VourMa, @GiacomoSguazzoni, @VinInn, @rovere, @makortel this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85f828/36007/summary.html
COMMIT: e50b349
CMSSW: CMSSW_14_0_X_2023-11-22-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43356/36007/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 23 lines to the logs
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3363868
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3363832
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1