-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CaloParticles in the barrel for Phase2 and introduce LC associations #43248
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43248/37615
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43248/37616
|
A new Pull Request was created by @brusale (Alessandro Brusamolino) for master. It involves the following packages:
@AdrianoDee, @mdhildreth, @cmsbuild, @syuvivida, @rvenditti, @antoniovagnerini, @tjavaid, @nothingface0, @civanch, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
-1 Failed Tests: Build BuildI found compilation error when building: >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/RecoHGCal/TICL/plugins/TrackstersMergeProducer.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/RecoHGCal/TICL/plugins/TrackstersMergeProducerV3.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/RecoHGCal/TICL/plugins/TrackstersPCA.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/RecoHGCal/TICL/plugins/TrackstersProducer.cc >> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/RecoHGCal/TICL/plugins/filters.cc /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/RecoHGCal/TICL/plugins/SimTrackstersProducer.cc:88:33: error: 'SimToRecoCollectionWithSimClusters' is not a member of 'hgcal'; did you mean 'ticl::SimToRecoCollectionWithSimClusters'? 88 | const edm::EDGetTokenT associatorMapSimClusterToReco_token_; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/SimDataFormats/Associations/interface/LayerClusterToSimClusterAssociator.h:10, from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/RecoHGCal/TICL/plugins/SimTrackstersProducer.cc:26: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-11-10-2300/src/SimDataFormats/Associations/interface/LayerClusterToSimClusterAssociatorBaseImpl.h:23:7: note: 'ticl::SimToRecoCollectionWithSimClusters' declared here |
-1 Failed Tests: RelVals RelVals-INPUT AddOn RelVals
RelVals-INPUT
Expand to see more relval errors ...AddOn Tests
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43248/37634
|
Pull request #43248 was updated. @rvenditti, @syuvivida, @cmsbuild, @mdhildreth, @antoniovagnerini, @srimanob, @jfernan2, @tjavaid, @civanch, @mandrenguyen, @AdrianoDee, @nothingface0 can you please check and sign again. |
@cmsbuild please test |
-1 Failed Tests: RelVals RelVals
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43248/37726
|
Pull request #43248 was updated. @nothingface0, @tjavaid, @antoniovagnerini, @syuvivida, @civanch, @srimanob, @AdrianoDee, @cmsbuild, @rvenditti, @mdhildreth, @jfernan2, @mandrenguyen can you please check and sign again. |
PR description:
This PR enables the creation of CaloParticles in both ECAL and HCAL for Phase2. In addition, LayerCluster to CaloParticle and LayerCluster to SimCluster associations (described here and used in
SimCalorimetry/HGCalAssociatorProducers
) are introduced for the barrel region. Also,namespace hgcal
has been changed intonamespace ticl
.PR validation:
Tested on workflows
24896.0
and24900.0
.@felicepantaleo @rovere @thomreis @valsdav @bmarzocc @hatakeyamak