Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HLT tau filtering based on jet-tags (ParticleNet) [13_2_X] #43122

Merged

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Oct 26, 2023

PR description:

This PR adds an HLT filter of tau candidates based on jet-tagger scores. This filter, in particular, enables tau filtering based on particle-net.
The PR introduces the following changes:

  • Adds TauTagFilter: an event filter based on the number of tau candidates that pass a selection which combines kinematic requirements (pt, eta) and requirements on jet-tagging. Optionally it also requires a matching with seeds and applies a pt correction;
  • Moves TauWPThreshold utility class from DeepTauId code to a separate file to be used by both DeepTauId and TauTagFilter (and possibly others in future);
  • Fixes L2TauTagFilter.cc to set correct id to output object.

No changes are expected in existing workflows (except correct id of objects returned by L2TauTagFilter).

Detailed performance of new HLT paths using newly introduced TauTagFilter and based on particle-net taggers presented at the TSG meeting on 2023-10-25: link to indico.

PR validation:

Code tested using CMSSW_13_3_0_pre3 with a custom HLT python configuration (with MC): hltMC_PNet_tau.py

If this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #43100 to 13_2_X release series for HLT integration.

kandrosov and others added 4 commits October 26, 2023 11:42
…ype of objs to match, address case of matching dR<0 and code-formatting

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 26, 2023

A new Pull Request was created by @mbluj for CMSSW_13_2_X.

It involves the following packages:

  • RecoTauTag/HLTProducers (hlt)
  • RecoTauTag/RecoTau (reconstruction)

@Martin-Grunewald, @mandrenguyen, @missirol, @mmusich, @jfernan2, @cmsbuild can you please review it and eventually sign? Thanks.
@missirol, @azotz, @mbluj, @silviodonato this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Oct 26, 2023

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Oct 26, 2023

backport of #43100

@mmusich
Copy link
Contributor

mmusich commented Oct 26, 2023

type tau

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff596d/35432/summary.html
COMMIT: 23bcb84
CMSSW: CMSSW_13_2_X_2023-10-26-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43122/35432/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198785
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198750
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Oct 26, 2023

+hlt

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 42edd81 into cms-sw:CMSSW_13_2_X Oct 29, 2023
@mbluj mbluj deleted the CMSSW_13_2_X_tau-pog_pnetTauAtHLT branch September 13, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants