-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing namespace to isnan calls #43104
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43104/37348
|
A new Pull Request was created by @iarspider for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43104/37350
|
Pull request #43104 was updated. @rvenditti, @syuvivida, @mandrenguyen, @nothingface0, @antoniovagnerini, @tjavaid, @cmsbuild, @jfernan2 can you please check and sign again. |
please test |
@cms-sw/dqm-l2 @cms-sw/reconstruction-l2 can you please review this. It is just a technical fix ( adding missing |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e67a65/35426/summary.html Comparison SummarySummary:
|
+1 |
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
@rappoccio @antoniovilela , can we merge this before 11h00 IB? This is needed for ROOT master IBs |
+1 |
PR description:
See description. Technical fix, required to update ROOTmaster
PR validation:
Bot tests here + cms-sw/cmsdist#8777