Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control maximum number of process to run for generating validation plots #43096

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Oct 24, 2023

As noticed in #43077 , unit test Validation/RecoTrack/test/testMakeTrackValidationPlots does not have any control over how many paralell jobs should be running for generating validation plots. This PR added the option to control the parallel running jobs. Default is to run # of CPUs jobs.

The unit tests testMakeTrackValidationPlots is change to run max of 4 jobs.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43096/37334

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • Validation/HGCalValidation (dqm)
  • Validation/RecoTrack (dqm)

@antoniovagnerini, @cmsbuild, @rvenditti, @syuvivida, @tjavaid, @nothingface0 can you please review it and eventually sign? Thanks.
@dgulhan, @hatakeyamak, @rovere, @felicepantaleo, @VinInn, @ebrondol, @apsallid, @bsunanda, @pfs, @wmtford, @cseez, @GiacomoSguazzoni, @JanFSchulte, @vandreev11, @mmusich, @sethzenz, @youyingli, @lecriste, @lgray, @VourMa, @mtosi, @missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Oct 24, 2023

the changes look reasonable to me
@smuzaffar thank you

@smuzaffar
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43096/37344

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

Pull request #43096 was updated. @rvenditti, @nothingface0, @antoniovagnerini, @syuvivida, @tjavaid can you please check and sign again.

@smuzaffar
Copy link
Contributor Author

abort

@smuzaffar smuzaffar force-pushed the validation-plots-process branch from 426725f to 9a4c0ab Compare October 24, 2023 16:54
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43096/37346

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

Pull request #43096 was updated. @syuvivida, @tjavaid, @rvenditti, @nothingface0, @antoniovagnerini can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1beac7/35395/summary.html
COMMIT: 9a4c0ab
CMSSW: CMSSW_13_3_X_2023-10-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43096/35395/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3357400
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3357375
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

@cms-sw/dqm-l2 can you please review this change. It should fix the issue reported in #43077 ( running a lot of processes in parallel).

@tjavaid
Copy link

tjavaid commented Oct 31, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 89aed25 into cms-sw:master Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants