-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control maximum number of process to run for generating validation plots #43096
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43096/37334
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @rvenditti, @syuvivida, @tjavaid, @nothingface0 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
the changes look reasonable to me |
please test |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43096/37344
|
Pull request #43096 was updated. @rvenditti, @nothingface0, @antoniovagnerini, @syuvivida, @tjavaid can you please check and sign again. |
abort |
426725f
to
9a4c0ab
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43096/37346
|
Pull request #43096 was updated. @syuvivida, @tjavaid, @rvenditti, @nothingface0, @antoniovagnerini can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1beac7/35395/summary.html Comparison SummarySummary:
|
@cms-sw/dqm-l2 can you please review this change. It should fix the issue reported in #43077 ( running a lot of processes in parallel). |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
As noticed in #43077 , unit test
Validation/RecoTrack/test/testMakeTrackValidationPlots
does not have any control over how many paralell jobs should be running for generating validation plots. This PR added the option to control the parallel running jobs. Default is to run # of CPUs jobs.The unit tests
testMakeTrackValidationPlots
is change to run max of4
jobs.