Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond - 132X #42946

thomreis · 2023-10-04T15:21:20Z

PR description:

This PR sets the default ECAL timing algorithm to the ratio method. This is the default timing algorithm for Run 1 and Run 2.
For Run 3 and Phase 2 a new modifier run3_ecal is used to change the timing algorithm to CC timing and use different records with the label 'CC' for the timing calibrations and timing offset constants.

Note that this behaviour is different than what was discussed in the meeting on the 27th Sept. when the plan was made to make the CC timing the default and use eras to modify Run 1 and Run 2 configurations to use the ratio method. Since Run 1 configurations could not be modified using eras we decided to reverse the behaviour as in the description above.

Backport of #42928

PR validation:

The PR passes Run 1 and Run2 WFs in the limited matrix tests but currently fails all Run 3 and Phase 2 WFs because the consumed records with the 'CC' label are not yet in the GTs.

…3 and use ratio timing for Run1 and Run2.

cmsbuild · 2023-10-04T15:21:41Z

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_13_2_X.

It involves the following packages:

Configuration/Eras (operations)
RecoLocalCalo/EcalRecProducers (reconstruction)

@davidlange6, @fabiocos, @antoniovilela, @mandrenguyen, @cmsbuild, @rappoccio, @jfernan2 can you please review it and eventually sign? Thanks.
@thomreis, @rchatter, @AnnikaStein, @youyingli, @fabiocos, @argiro, @wang0jin, @missirol, @apsallid, @Martin-Grunewald, @makortel this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Backported from Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond #42928

thomreis · 2023-10-04T15:24:01Z

type ecal

thomreis · 2023-10-04T15:24:14Z

backport of #42928

saumyaphor4252 · 2023-10-06T11:48:41Z

assign alca

Need to be followed up closely to deploy for data-taking at T0 with compatible GTs and replay

cmsbuild · 2023-10-06T11:49:05Z

New categories assigned: alca

@saumyaphor4252,@perrotta,@consuegs you have been requested to review this Pull request/Issue and eventually sign? Thanks

mandrenguyen · 2023-10-10T13:27:00Z

please test

cmsbuild · 2023-10-10T21:53:23Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe4774/35107/summary.html
COMMIT: 5112c3b
CMSSW: CMSSW_13_2_X_2023-10-09-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42946/35107/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 3 errors in the following unit tests:

---> test TestDQMOnlineClient-ecal_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-visualization had ERRORS
---> test TestDQMOnlineClient-visualization_secondInstance had ERRORS

RelVals

138.4

----- Begin Fatal Exception 10-Oct-2023 23:01:41 CEST-----------------------
An exception of category 'NoProductResolverException' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'dqmoffline_step'
   [2] Prefetching for module DQMMessageLogger/'DQMMessageLogger'
   [3] Prefetching for module LogErrorHarvester/'logErrorHarvester'
   [4] Prefetching for module EcalRecHitProducer/'ecalRecHit@cpu'
   [5] Calling method for module EcalUncalibRecHitProducer/'ecalMultiFitUncalibRecHit@cpu'
Exception Message:
No data of type "EcalTimeOffsetConstant" with label "CC" in record "EcalTimeOffsetConstantRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

138.5

----- Begin Fatal Exception 10-Oct-2023 23:01:55 CEST-----------------------
An exception of category 'NoProductResolverException' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'dqmoffline_13_step'
   [2] Prefetching for module SMPDQM/'SMPDQM'
   [3] Prefetching for module MuonProducer/'muons'
   [4] Prefetching for module MuonIdProducer/'muons1stStep'
   [5] Prefetching for module EcalRecHitProducer/'ecalRecHit@cpu'
   [6] Calling method for module EcalUncalibRecHitProducer/'ecalMultiFitUncalibRecHit@cpu'
Exception Message:
No data of type "EcalTimeOffsetConstant" with label "CC" in record "EcalTimeOffsetConstantRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

139.001

----- Begin Fatal Exception 10-Oct-2023 23:06:11 CEST-----------------------
An exception of category 'NoProductResolverException' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'dqmofflineOnPAT_1_step'
   [2] Prefetching for module SingleTopTChannelLeptonDQM_miniAOD/'singleTopElectronMediumDQM_miniAOD'
   [3] Prefetching for module PATMuonSlimmer/'slimmedMuons'
   [4] Prefetching for module PATMuonSelector/'selectedPatMuons'
   [5] Prefetching for module PATMuonProducer/'patMuons'
   [6] Prefetching for module MuonProducer/'muons'
   [7] Prefetching for module MuonIdProducer/'muons1stStep'
   [8] Prefetching for module EcalRecHitProducer/'ecalRecHit@cpu'
   [9] Calling method for module EcalUncalibRecHitProducer/'ecalMultiFitUncalibRecHit@cpu'
Exception Message:
No data of type "EcalTimeOffsetConstant" with label "CC" in record "EcalTimeOffsetConstantRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

139.005139.005_AlCaPhiSym2021/step2_AlCaPhiSym2021.log
138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log
138.5138.5_ExpressCollisions2021/step2_ExpressCollisions2021.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 10-Oct-2023 23:05:30 CEST-----------------------
An exception of category 'NoProductResolverException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module CaloTowersCreator/'towerMaker'
   [4] Prefetching for module EcalRecHitProducer/'ecalRecHit@cpu'
   [5] Calling method for module EcalUncalibRecHitProducer/'ecalMultiFitUncalibRecHit@cpu'
Exception Message:
No data of type "EcalTimeOffsetConstant" with label "CC" in record "EcalTimeOffsetConstantRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

hlt_mc_HIon

----- Begin Fatal Exception 10-Oct-2023 23:04:22 CEST-----------------------
An exception of category 'NoProductResolverException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module CaloTowersCreator/'towerMaker'
   [4] Prefetching for module EcalRecHitProducer/'ecalRecHit@cpu'
   [5] Calling method for module EcalUncalibRecHitProducer/'ecalMultiFitUncalibRecHit@cpu'
Exception Message:
No data of type "EcalTimeOffsetConstant" with label "CC" in record "EcalTimeOffsetConstantRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

hlt_mc_PIon

----- Begin Fatal Exception 10-Oct-2023 23:03:46 CEST-----------------------
An exception of category 'NoProductResolverException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 3
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module CaloTowersCreator/'towerMaker'
   [4] Prefetching for module EcalRecHitProducer/'ecalRecHit@cpu'
   [5] Calling method for module EcalUncalibRecHitProducer/'ecalMultiFitUncalibRecHit@cpu'
Exception Message:
No data of type "EcalTimeOffsetConstant" with label "CC" in record "EcalTimeOffsetConstantRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

thomreis · 2023-10-10T22:37:26Z

This PR needs GT updates like in #42958 in order to pass the tests.

thomreis · 2023-10-16T09:54:50Z

test parameters:

pull_requests=[13_2_X] Include ECAL Timing CC labelled tags in Run3 data and MC GTs #43019,Use the ratio timing method for ECAL online DQM- 132X part 2 #43024

thomreis · 2023-10-16T09:56:10Z

please test

thomreis · 2023-11-15T09:27:56Z

Hi @perrotta our validators are looking at the this at the moment.

AdrianoDee · 2023-11-26T17:05:41Z

Hi, we are starting to see good reports for 13_3_0_pre4 EGM so most probably we could include this, unless I'm missing something. Then, we (PdmV) would cut a 13_2_X release with this in to have a small validation from EGM people also for 13_2_X (analogously to what is being done for 13_1_X). What do you think? We can discuss it at the next ORP, of course.

perrotta · 2023-11-27T07:57:13Z

Hi, we are starting to see good reports for 13_3_0_pre4 EGM so most probably we could include this, unless I'm missing something. Then, we (PdmV) would cut a 13_2_X release with this in to have a small validation from EGM people also for 13_2_X (analogously to what is being done for 13_1_X). What do you think? We can discuss it at the next ORP, of course.

Thank you @AdrianoDee. The possible issue with 13_2_X is that it is a production release, already used for HI data taking, and going to be put in production for the HI MC. I would wait for a full green light from the validators in 13_3_0_pre4 (as far as I understand, "we are starting to see good reports" does not mean the validation is already successfully ended). I think that at that point we can proceed with including this in 13_2_X, and produce the small validation sample for EGM that you are suggesting, which is a welcome last check for this.

perrotta · 2023-11-27T07:57:58Z

please test
(Assuming we are very close to the final validation results, let refresh the tests)

cmsbuild · 2023-11-27T11:04:39Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe4774/36074/summary.html
COMMIT: 5112c3b
CMSSW: CMSSW_13_2_X_2023-11-26-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42946/36074/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 132 lines to the logs
Reco comparison results: 20228 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3198785
DQMHistoTests: Total failures: 4046
DQMHistoTests: Total nulls: 6
DQMHistoTests: Total successes: 3194711
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.023 KiB( 47 files compared)
DQMHistoSizes: changed ( 4.53 ): -0.023 KiB JetMET/SUSYDQM
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: found differences in 5 / 46 workflows

AdrianoDee · 2023-11-27T12:44:37Z

@perrotta fair enough. Yes, not the full release, for the moment I was referring to the EGM reports (that were the failing ones due to timing algo changes).

AdrianoDee · 2023-12-18T10:48:16Z

please test

AdrianoDee · 2023-12-18T10:53:41Z

All the latest reports from EGM including this PR are green:

Electrons and Photons 13_3_0_pre5 2023
Electrons and Photons 13_3_0_pre5 Phase2.

This was the case for 2023 also in 13_3_0_pre4 (the first pre where the original PR was included). In general for 13_3_0_pre4 (opened 1 month ago) there is no failure report for 2023.

cmsbuild · 2023-12-18T14:32:15Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe4774/36544/summary.html
COMMIT: 5112c3b
CMSSW: CMSSW_13_2_X_2023-12-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42946/36544/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 123 lines to the logs
Reco comparison results: 20229 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3198830
DQMHistoTests: Total failures: 4001
DQMHistoTests: Total nulls: 6
DQMHistoTests: Total successes: 3194801
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.023 KiB( 47 files compared)
DQMHistoSizes: changed ( 4.53 ): -0.023 KiB JetMET/SUSYDQM
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: found differences in 5 / 46 workflows

perrotta · 2023-12-19T06:56:04Z

+alca

Given the positive feedback of the validations reported here above
To be merged together with [13_2_X] Include ECAL Timing CC labelled tags in Run3 data and MC GTs #43019

antoniovilela · 2023-12-19T15:52:09Z

+1

cmsbuild · 2023-12-19T15:52:29Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will be automatically merged.

Get the CC labelled timing conditions for ECAL reconstruction for Run…

5112c3b

…3 and use ratio timing for Run1 and Run2.

cmsbuild added this to the CMSSW_13_2_X milestone Oct 4, 2023

cmsbuild added reconstruction-pending operations-pending pending-signatures tests-pending orp-pending labels Oct 4, 2023

cmsbuild added backport ecal labels Oct 4, 2023

saumyaphor4252 mentioned this pull request Oct 5, 2023

Include ECAL Timing CC labelled tags in Run3 data and MC GTs #42958

Merged

cmsbuild added the alca-pending label Oct 6, 2023

cmsbuild added tests-started backport-ok and removed tests-pending backport labels Oct 10, 2023

cmsbuild added tests-rejected and removed tests-started labels Oct 10, 2023

saumyaphor4252 mentioned this pull request Oct 13, 2023

[13_2_X] Include ECAL Timing CC labelled tags in Run3 data and MC GTs #43019

Merged

thomreis mentioned this pull request Oct 16, 2023

Use the ratio timing method for ECAL online DQM- 132X part 2 #43024

Merged

cmsbuild added the requires-external label Oct 16, 2023

cmsbuild added tests-started and removed tests-approved labels Nov 27, 2023

cmsbuild added tests-approved and removed tests-started labels Nov 27, 2023

cmsbuild added tests-started and removed tests-approved labels Dec 18, 2023

cmsbuild added tests-approved and removed tests-started labels Dec 18, 2023

cmsbuild added alca-approved and removed alca-pending labels Dec 19, 2023

cmsbuild added operations-approved fully-signed orp-approved and removed operations-pending pending-signatures orp-pending labels Dec 19, 2023

cmsbuild merged commit 324e582 into cms-sw:CMSSW_13_2_X Dec 19, 2023
11 checks passed

thomreis deleted the ecal-default-timing-cond-records-132x branch December 20, 2023 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond - 132X #42946

Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond - 132X #42946

thomreis commented Oct 4, 2023

cmsbuild commented Oct 4, 2023 •

edited

Loading

thomreis commented Oct 4, 2023

thomreis commented Oct 4, 2023

saumyaphor4252 commented Oct 6, 2023

cmsbuild commented Oct 6, 2023

mandrenguyen commented Oct 10, 2023

cmsbuild commented Oct 10, 2023

thomreis commented Oct 10, 2023

thomreis commented Oct 16, 2023

thomreis commented Oct 16, 2023

thomreis commented Nov 15, 2023

AdrianoDee commented Nov 26, 2023

perrotta commented Nov 27, 2023

perrotta commented Nov 27, 2023

cmsbuild commented Nov 27, 2023

AdrianoDee commented Nov 27, 2023

AdrianoDee commented Dec 18, 2023

AdrianoDee commented Dec 18, 2023

cmsbuild commented Dec 18, 2023

perrotta commented Dec 19, 2023

antoniovilela commented Dec 19, 2023

cmsbuild commented Dec 19, 2023

Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond - 132X #42946

Use ECAL ratio timing algorithm for Run 1 and Run 2, and CC timing algorithm for Run 3 and beyond - 132X #42946

Conversation

thomreis commented Oct 4, 2023

PR description:

PR validation:

cmsbuild commented Oct 4, 2023 • edited Loading

thomreis commented Oct 4, 2023

thomreis commented Oct 4, 2023

saumyaphor4252 commented Oct 6, 2023

cmsbuild commented Oct 6, 2023

mandrenguyen commented Oct 10, 2023

cmsbuild commented Oct 10, 2023

Unit Tests

RelVals

RelVals-INPUT

AddOn Tests

thomreis commented Oct 10, 2023

thomreis commented Oct 16, 2023

thomreis commented Oct 16, 2023

thomreis commented Nov 15, 2023

AdrianoDee commented Nov 26, 2023

perrotta commented Nov 27, 2023

perrotta commented Nov 27, 2023

cmsbuild commented Nov 27, 2023

Comparison Summary

AdrianoDee commented Nov 27, 2023

AdrianoDee commented Dec 18, 2023

AdrianoDee commented Dec 18, 2023

cmsbuild commented Dec 18, 2023

Comparison Summary

perrotta commented Dec 19, 2023

antoniovilela commented Dec 19, 2023

cmsbuild commented Dec 19, 2023

cmsbuild commented Oct 4, 2023 •

edited

Loading