Rename `MaxNumberOfCosmicClusters` parameter in `ClusterChecker` #42943

mmusich · 2023-10-04T11:05:01Z

PR description:

This PR is purely technical, rename MaxNumberOfCosmicClusters into MaxNumberOfStripClusters in ClusterChecker as it is currently misleading and still there only for "historical reasons" (see a551c6e).
Some gymnastics is required in order to apply the change in the existing HLT configurations.
No regressions are expected.

PR validation:

Run successfully:

addOnTests.py
runTheMatrix.py -l limited --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, no backport is needed.

…umberOfStripClusters

…MaxNumberOfStripClusters in the HLT menus

…hase-2 HLT menus

cmsbuild · 2023-10-04T11:14:11Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42943/37091

This PR adds an extra 80KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): revert PR 40443 w/o introducing bricked pixels #42454

cmsbuild · 2023-10-04T11:14:36Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/GlobalRuns (operations)
DQM/Integration (dqm)
HLTrigger/Configuration (hlt)
HLTrigger/special (hlt)
RecoHI/HiTracking (reconstruction)
RecoTracker/Configuration (reconstruction)
RecoTracker/ConversionSeedGenerators (reconstruction)
RecoTracker/SpecialSeedGenerators (reconstruction)
RecoTracker/TkSeedGenerator (reconstruction)
SimGeneral/DataMixingModule (simulation)

@mandrenguyen, @antoniovilela, @fabiocos, @rappoccio, @tjavaid, @nothingface0, @jfernan2, @Martin-Grunewald, @missirol, @civanch, @rvenditti, @syuvivida, @davidlange6, @cmsbuild, @mdhildreth, @antoniovagnerini, @mmusich can you please review it and eventually sign? Thanks.
@felicepantaleo, @dgulhan, @jazzitup, @gpetruc, @JanFSchulte, @VourMa, @Martin-Grunewald, @slomeo, @GiacomoSguazzoni, @ebrondol, @VinInn, @mtosi, @silviodonato, @mandrenguyen, @yenjie, @threus, @makortel, @fabiocos, @batinkov, @francescobrivio, @yetkinyilmaz, @rovere, @kurtejung, @SohamBhattacharya, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2023-10-04T12:09:42Z

please test

cmsbuild · 2023-10-04T13:43:54Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c47898/35040/summary.html
COMMIT: 8ec9dc6
CMSSW: CMSSW_13_3_X_2023-10-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42943/35040/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

1000.0

----- Begin Fatal Exception 04-Oct-2023 14:52:08 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root
      [c] Input file root://xrootd-cms.infn.it//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root?tried=+1213llrxrd-redir.in2p3.fr,&xrdcl.requuid=81949bf0-e1f3-447d-826a-9a8152acd45a
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

10224.0

----- Begin Fatal Exception 04-Oct-2023 14:53:30 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_12_0_0_pre4/RelValMinBias_13/GEN-SIM/113X_mc2017_realistic_v5-v1/00000/1888d3ef-3019-4e81-bf79-7e50c5657e64.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://cms-xrd-global.cern.ch//eos/cms/store/relval/CMSSW_12_0_0_pre4/RelValMinBias_13/GEN-SIM/113X_mc2017_realistic_v5-v1/00000/1888d3ef-3019-4e81-bf79-7e50c5657e64.root
      [b] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_12_0_0_pre4/RelValMinBias_13/GEN-SIM/113X_mc2017_realistic_v5-v1/00000/1888d3ef-3019-4e81-bf79-7e50c5657e64.root
      [c] Input file root://xrootd-cms.infn.it//store/relval/CMSSW_12_0_0_pre4/RelValMinBias_13/GEN-SIM/113X_mc2017_realistic_v5-v1/00000/1888d3ef-3019-4e81-bf79-7e50c5657e64.root could not be opened.
      [d] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_12_0_0_pre4/RelValMinBias_13/GEN-SIM/113X_mc2017_realistic_v5-v1/00000/1888d3ef-3019-4e81-bf79-7e50c5657e64.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] No servers are available to read the file.�
' (errno=3011, code=400). No additional data servers were found.
      [e] Last URL tried: root://cms-xrd-global.cern.ch:1094//store/relval/CMSSW_12_0_0_pre4/RelValMinBias_13/GEN-SIM/113X_mc2017_realistic_v5-v1/00000/1888d3ef-3019-4e81-bf79-7e50c5657e64.root?tried=+1213xrootd-redic.pi.infn.it,&xrdcl.requuid=eb230e08-5efd-4dfd-a79f-35b6100d8649
      [f] Problematic data server: cms-xrd-global.cern.ch:1094
      [g] Disabled source: cms-xrd-global.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

140.031140.031_RunMuonEG2022B/step2_RunMuonEG2022B.log
140.045140.045_RunJetHT2022C/step2_RunJetHT2022C.log
140.049140.049_RunTau2022C/step2_RunTau2022C.log

Expand to see more relval errors ...

mmusich · 2023-10-04T14:48:27Z

@cmsbuild, please test

looks like a glitch in eos / xrootd, let's try again

jfernan2 · 2023-10-04T15:54:29Z

HLTrigger/Configuration/python/customizeHLTforCMSSW.py

+        if hasattr(prod, "ClusterCheckPSet"):
+            clustCheckPSet = getattr(prod,"ClusterCheckPSet")
+            prod.ClusterCheckPSet.MaxNumberOfStripClusters = getattr(clustCheckPSet,"MaxNumberOfCosmicClusters")
+            clustCheckPSet.__delattr__("MaxNumberOfCosmicClusters")


Shouldn't this be "MaxNumberOfStripClusters" ?

No. MaxNumberOfStripClusters in the name of the new parameter. Here I am deleting the old one (which if mainained would make the configuration validation fail).

cmsbuild · 2023-10-04T17:30:58Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c47898/35042/summary.html
COMMIT: 8ec9dc6
CMSSW: CMSSW_13_3_X_2023-10-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42943/35042/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3356920
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3356895
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

jfernan2 · 2023-10-05T10:57:43Z

+1

civanch · 2023-10-05T14:12:15Z

+1

mmusich · 2023-10-07T16:03:51Z

+hlt

mmusich · 2023-10-07T16:04:15Z

@cms-sw/dqm-l2 your signature is required here

tjavaid · 2023-10-07T16:12:36Z

+1

antoniovilela · 2023-10-09T15:59:55Z

+1

cmsbuild · 2023-10-09T16:00:24Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cmsbuild added this to the CMSSW_13_3_X milestone Oct 4, 2023

cmsbuild added reconstruction-pending simulation-pending dqm-pending hlt-pending operations-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels Oct 4, 2023

mmusich added 3 commits October 4, 2023 13:06

rename MaxNumberOfCosmicClusters parameters in ClusterChecker to MaxN…

e282ba8

…umberOfStripClusters

add customization function for changing MaxNumberOfCosmicClusters -> …

5a1f751

…MaxNumberOfStripClusters in the HLT menus

change MaxNumberOfCosmicClusters -> MaxNumberOfStripClusters in the P…

8ec9dc6

…hase-2 HLT menus

mmusich force-pushed the renameMaxNumberOfCosmicClusters branch from 4e6e4cc to 8ec9dc6 Compare October 4, 2023 11:06

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 4, 2023

cmsbuild added tests-started and removed tests-pending labels Oct 4, 2023

cmsbuild added tests-rejected and removed tests-started labels Oct 4, 2023

cmsbuild added tests-started and removed tests-rejected labels Oct 4, 2023

jfernan2 reviewed Oct 4, 2023

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Oct 4, 2023

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 5, 2023

cmsbuild added simulation-approved and removed simulation-pending labels Oct 5, 2023

cmsbuild mentioned this pull request Oct 5, 2023

Adding DeepFlavour Jet tags to BTV DQM #42937

Merged

cmsbuild added hlt-approved and removed hlt-pending labels Oct 7, 2023

cmsbuild added dqm-approved and removed dqm-pending labels Oct 7, 2023

cmsbuild added operations-approved fully-signed orp-approved and removed operations-pending pending-signatures orp-pending labels Oct 9, 2023

cmsbuild merged commit 7cb553d into cms-sw:master Oct 9, 2023
11 checks passed

mmusich deleted the renameMaxNumberOfCosmicClusters branch October 9, 2023 16:02

This was referenced Oct 9, 2023

Deterministic DRN #42950

Merged

Custom Run 3 PFScouting NanoAOD #40438

Merged

[ROOT6] Updated root to tip of branch master cms-sw/cmsdist#8743

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename `MaxNumberOfCosmicClusters` parameter in `ClusterChecker` #42943

Rename `MaxNumberOfCosmicClusters` parameter in `ClusterChecker` #42943

mmusich commented Oct 4, 2023 •

edited

Loading

cmsbuild commented Oct 4, 2023

cmsbuild commented Oct 4, 2023

mmusich commented Oct 4, 2023

cmsbuild commented Oct 4, 2023

mmusich commented Oct 4, 2023

jfernan2 Oct 4, 2023

mmusich Oct 4, 2023 •

edited

Loading

cmsbuild commented Oct 4, 2023

jfernan2 commented Oct 5, 2023

civanch commented Oct 5, 2023

mmusich commented Oct 7, 2023

mmusich commented Oct 7, 2023

tjavaid commented Oct 7, 2023

antoniovilela commented Oct 9, 2023

cmsbuild commented Oct 9, 2023

Rename MaxNumberOfCosmicClusters parameter in ClusterChecker #42943

Rename MaxNumberOfCosmicClusters parameter in ClusterChecker #42943

Conversation

mmusich commented Oct 4, 2023 • edited Loading

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Oct 4, 2023

cmsbuild commented Oct 4, 2023

mmusich commented Oct 4, 2023

cmsbuild commented Oct 4, 2023

RelVals

RelVals-INPUT

mmusich commented Oct 4, 2023

jfernan2 Oct 4, 2023

Choose a reason for hiding this comment

mmusich Oct 4, 2023 • edited Loading

Choose a reason for hiding this comment

cmsbuild commented Oct 4, 2023

Comparison Summary

jfernan2 commented Oct 5, 2023

civanch commented Oct 5, 2023

mmusich commented Oct 7, 2023

mmusich commented Oct 7, 2023

tjavaid commented Oct 7, 2023

antoniovilela commented Oct 9, 2023

cmsbuild commented Oct 9, 2023

Rename `MaxNumberOfCosmicClusters` parameter in `ClusterChecker` #42943

Rename `MaxNumberOfCosmicClusters` parameter in `ClusterChecker` #42943

mmusich commented Oct 4, 2023 •

edited

Loading

mmusich Oct 4, 2023 •

edited

Loading