Fix for pixel FED error imbalance in DQM plots

[ferencek]

PR description:

After recent bug fixes in FED error decoding in the CPU (#42010) and GPU (#42618) code, the following imbalance was still present in the SiPixelHeterogeneous/PixelErrorCompareGPUvsCPU/FEErrorVsFEDIdUnbalance DQM plot

This imbalance is primarily present because the GPU-based pixel unpacker is not dropping spurious errors assigned to invalid DetIds. Specifically for the timeout error (errorType=29), which consists of two error words, the GPU code was not dropping the 2nd word as is done in the CPU code. This PR therefore additionally synchronizes the FED error handling between the GPU and the legacy CPU code. The same DQM plot with this PR included becomes empty (no imbalance present)

PR validation:

The code was tested and the above DQM plots obtained by running the following workflow

runTheMatrix.py -w gpu -l 141.008583

recently introduced in #42674.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Could be backported to 13_2_X if needed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42872/37009

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): [DO NOT MERGE] remove duplicate pixels #37359, [13_2_X] EMTF add DQM plots for unconstrained pT and dxy #42864

[cmsbuild]

A new Pull Request was created by @ferencek (Dinko F.) for master.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@mtosi, @VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mroguljic, @missirol, @dkotlins, @ferencek, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

test parameters:

• enable = gpu
• workflows_gpu = 11634.503, 11634.507, 11634.583, 11634.587, 11634.593
• relvals_opt_gpu = --what upgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix,nano
• addpkg = DQM/Integration

[mmusich]

@cmsbuild, please test

[mmusich]

@ferencek this looks desireable also for 13.2.X (data-taking release at HLT), would you mind opening a backport?

[ferencek]

@mmusich, ok, no problem, I will also make a backport PR.

[mmusich]

type bug-fix

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cea758/34909/summary.html
COMMIT: 708c739
CMSSW: CMSSW_13_3_X_2023-09-26-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42872/34909/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3358044
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3358016
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 75 differences found in the comparisons
• DQMHistoTests: Total files compared: 8
• DQMHistoTests: Total histograms compared: 227211
• DQMHistoTests: Total failures: 2374
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 224837
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 7 files compared)
• Checked 28 log files, 35 edm output root files, 8 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1