Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD geometry: add test for pixel acceptance in module #42739

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Sep 8, 2023

PR description:

A test to evaluate the effective acceptance of logical pixels in MTD modules as provided by the RectangularMTDTopology class is added. The test is based on a trivial MonteCarlo estimate of the fraction of random points contained into the pixels. This update provides just output on the STDOUT for visual inspection and does nto affect the content of the file used for comparisons in the unit test procedure.

PR validation:

The code has been used in the investigation of the track-hit matching efficiency in ETL, helping to understand issues with the pixel definition.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2023

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42739/36829

  • This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42739/36830

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2023

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

  • Geometry/MTDGeometryBuilder (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@bsunanda this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 8, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e104e/34665/summary.html
COMMIT: a390194
CMSSW: CMSSW_13_3_X_2023-09-07-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42739/34665/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 337 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3153414
  • DQMHistoTests: Total failures: 125
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3153267
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@fabiocos
Copy link
Contributor Author

fabiocos commented Sep 8, 2023

Any change in the test is clearly unrelated from this PR, whose impact could just be on unit tests, where there is none.

@civanch
Copy link
Contributor

civanch commented Sep 8, 2023

+1

@makortel
Copy link
Contributor

makortel commented Sep 8, 2023

The comparison failures are related to #39803

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants