-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD geometry: add test for pixel acceptance in module #42739
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42739/36829
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42739/36830
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages:
@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e104e/34665/summary.html Comparison SummarySummary:
|
Any change in the test is clearly unrelated from this PR, whose impact could just be on unit tests, where there is none. |
+1 |
The comparison failures are related to #39803 |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
A test to evaluate the effective acceptance of logical pixels in MTD modules as provided by the
RectangularMTDTopology
class is added. The test is based on a trivial MonteCarlo estimate of the fraction of random points contained into the pixels. This update provides just output on the STDOUT for visual inspection and does nto affect the content of the file used for comparisons in the unit test procedure.PR validation:
The code has been used in the investigation of the track-hit matching efficiency in ETL, helping to understand issues with the pixel definition.