Fix LHCInfoPerLS PopCon incorrectly matching LS between OMS and PPS db

[JanChyczynski]

PR description:

Fixes a bug in LHCInfoPerLS PopCon: before it was writing a payload on a wrong IOV (corresponding to a different lumisection) or skipping a payload in these cases:

• start_time of lumisection in OMS greater or equal to DIP_UPDATE_TIME in PPS DB
• lumisection missing in OMS

Additionally it introduces logs monitoring payload quality to LHCInfoPerLS PopCon. It logs payloads with invalid values of beta star and crossing angle as well as missing records in the PPS DB.

PR validation:

Added validation of writing correct number of payloads for fill 7967 to the CondToolsLHCInfoNewPopConTest unit test. Before the fix payload on IOV 7119284725528657920 was skipped.

Backporting

I suspect it should be backproted back to 13_0_X but please confirm it.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42629/36685

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @JanChyczynski (jan_chyczynski) for master.

It involves the following packages:

• CondTools/RunInfo (db)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eec0ec/34423/summary.html
COMMIT: 370cb85
CMSSW: CMSSW_13_3_X_2023-08-22-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42629/34423/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test CondToolsLHCInfoNewPopConTest had ERRORS

Comparison Summary

Summary:

• You potentially removed 22 lines from the logs
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3153095
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153064
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42629/36717

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #42629 was updated. @perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please check and sign again.

[JanChyczynski]

I've run the unit test not realizing I didn't build the code after the last changes so I thought it was passing - stupid mistake. I've fixed it now.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eec0ec/34473/summary.html
COMMIT: 48a34fc
CMSSW: CMSSW_13_3_X_2023-08-24-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42629/34473/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 11 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3153095
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153070
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42629/36764

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #42629 was updated. @perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eec0ec/34516/summary.html
COMMIT: dbe2cd1
CMSSW: CMSSW_13_3_X_2023-08-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42629/34516/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 14 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3153095
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153067
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+db

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1