Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_2_X (1/N) [13_3_X] #42610

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_13_2_X.

This is the PR for the master branch, which will then be backported down to 13_2_X (the latter is the release cycle currently used for Run-3 HLT-menu development).

Since this is the first PR for the development of HLT menus in this release cycle, the "fake" and "frozen" menus in the release are also updated accordingly.

This update includes the integration of the following JIRA tickets.

  • CMSHLT-2863: [TSG] replace instances of HLTPFJetTagWithMatching with HLTPFJetTag
  • CMSHLT-2888: [TRK] replace instances of SiPixelRawToClusterCUDA with SiPixelRawToClusterCUDAPhase1
  • CMSHLT-2891: [LUM] remove AlCaPCC streams from HIon menu

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_13_2_X

Development of HLT menus for `CMSSW_13_2_X`.

Since this is the first PR for the development of HLT menus in this release cycle, the "fake" and "frozen" menus in the release are also updated accordingly.

This update includes the integration of the following JIRA tickets.

 - [CMSHLT-2863](https://its.cern.ch/jira/browse/CMSHLT-2863): [TSG] replace instances of `HLTPFJetTagWithMatching` with `HLTPFJetTag`
 - [CMSHLT-2888](https://its.cern.ch/jira/browse/CMSHLT-2888): [TRK] replace instances of `SiPixelRawToClusterCUDA` with `SiPixelRawToClusterCUDAPhase1`
 - [CMSHLT-2891](https://its.cern.ch/jira/browse/CMSHLT-2891): [LUM] remove AlCaPCC streams from HIon menu
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42610/36661

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

enable gpu

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae1c30/34369/summary.html
COMMIT: e03bc9f
CMSSW: CMSSW_13_3_X_2023-08-19-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42610/34369/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 174 lines to the logs
  • Reco comparison results: 45 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3152910
  • DQMHistoTests: Total failures: 257
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3152631
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.002 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12434.0,... ): -0.001 KiB HLT/Filters
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 40118
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 40097
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

  • Outputs of the PR tests are in line with the update of the HLT menus (GRun and "fake" menus). Differences are only technical (e.g. menu names), no physics changes.
  • Spurious DQM differences seen in several wfs, compatible with #42525 and #39754.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants