Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Update 2023 MC GTs with the fixed L1T tag and re-snapshot the data GTs #42372

Conversation

saumyaphor4252
Copy link
Contributor

PR description:

Backport of #42358

This PR updates the:

  • 2023 MC production GTs with the fixed L1T tag L1TMuonGlobalParams_Stage2v0_2023_mc_v2 to resolve the discrepancy observed in [1]. Also, see CMS Talk post [2] for the relevant tag details.
  • Run3 data GTs with updated snapshot time

[1] https://cms-pdmv.cern.ch/relmon/1688568203___CMSSW_13_2_0_pre2_2023vsCMSSW_13_1_0_pre4_2023/FullSimReport_HLT/RelValWToLNu_14TeV_131X_mcRun3_2023_realistic_v4_2023/7fdc3f5aa9.html
[2] https://cms-talk.web.cern.ch/t/mc-call-for-conditions-for-2023-mc/24376/23

GT Differences with respect to the last ones:

PR validation:

GTs tested locally with

  • runTheMatrix.py -l 138.2,138.4,139.001,140.106,140.111,141.031,141.032,141.036,141.038,12434.0,12434.7,12634.0,12634.99 -j 8 --ibeos
  • runTheMatrix.py -l 12400.0,12430.0,12440.0,12627.0,12643.0 --what upgrade -j 8 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #42358

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 25, 2023

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor Author

backport of #42358

@saumyaphor4252
Copy link
Contributor Author

test parameters:

  • workflows = 138.2,138.4,139.001,140.106,140.111,141.031,141.032,141.036,141.038,12434.0,12434.7,12634.0,12634.99

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-399d64/33895/summary.html
COMMIT: c367ad3
CMSSW: CMSSW_13_0_X_2023-07-25-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42372/33895/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 17 lines from the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 56
  • DQMHistoTests: Total histograms compared: 3985939
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3985908
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 55 files compared)
  • Checked 250 log files, 202 edm output root files, 56 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jul 29, 2023

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-399d64/33972/summary.html
COMMIT: c367ad3
CMSSW: CMSSW_13_0_X_2023-07-29-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42372/33972/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 206 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 56
  • DQMHistoTests: Total histograms compared: 3985939
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3985908
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 55 files compared)
  • Checked 250 log files, 202 edm output root files, 56 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Jul 31, 2023

@tvami
Copy link
Contributor

tvami commented Jul 31, 2023

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Aug 1, 2023

+1

@cmsbuild cmsbuild merged commit f2a0fcf into cms-sw:CMSSW_13_0_X Aug 1, 2023
@saumyaphor4252 saumyaphor4252 deleted the alca-130X-Fix_L1Ttag_in_2023MC_gts branch October 13, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants