fixed comparePayloads in LHCInfo* PopCons

[JanChyczynski]

PR description:

Fixed LHCInfo PopCon (LHCInfoPopConSourceHandler) and LHCInfoPerFill PopCon (LHCInfoPerFillPopConAnalyzer) skipping payloads because of bug in comparePayload. It was supposed to save a payload every time one of some variables change. Because of the bug, for some variables it was not saving the payload despite the change of the vaule.

PR validation:

Validated by:

1. running the PopCon script (LHCInfoPopConAnalyzerEndFill.py) for the fill 9019, producing local sqlite files with the payloads
2. comparing the contents of the produced files with the data for fill 9019 from PPS-DB

Backport:

It's going to be backported to CMSSW_13_2_X , CMSSW_13_1_X and CMSSW_13_0_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42360/36392

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondTools/RunInfo/plugins/LHCInfoPerFillPopConAnalyzer.cc modified in PR(s): [13_2_X] fixed comparePayloads in LHInfo* PopCons #42361
  • File CondTools/RunInfo/plugins/LHCInfoPerLSPopConAnalyzer.cc modified in PR(s): [13_2_X] fixed comparePayloads in LHInfo* PopCons #42361
  • File CondTools/RunInfo/src/LHCInfoPopConSourceHandler.cc modified in PR(s): [13_2_X] fixed comparePayloads in LHInfo* PopCons #42361

[cmsbuild]

A new Pull Request was created by @JanChyczynski (jan_chyczynski) for master.

It involves the following packages:

• CondTools/RunInfo (db)

@perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

type bugfix

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-305e35/33885/summary.html
COMMIT: 039781f
CMSSW: CMSSW_13_3_X_2023-07-25-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42360/33885/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150117
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3150089
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[francescobrivio]

+db

• tests cleamn
• PR according to description, also includes:
  • some code cleaning (remove duplication of theLHCInfoPerLSImpl::LumiSectionFilter code)
  • some application CMS coding rules

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

Failed Tests: HeaderConsistency RelVals-INPUT

In CondTools/RunInfo/interface/LumiSectionFilter.h the following include is missing:

#include "CondCore/CondDB/interface/Time.h"

Moreover, the same file CondTools/RunInfo/interface/LumiSectionFilter.h still misses a header guard

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42360/36420

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #42360 was updated. @perrotta, @consuegs, @cmsbuild, @saumyaphor4252, @francescobrivio, @tvami can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-305e35/33952/summary.html
COMMIT: 644e779
CMSSW: CMSSW_13_3_X_2023-07-27-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42360/33952/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3150821
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3150796
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[perrotta]

+db

• Pretty similar to the last one already signed by db...

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1