Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_1_X] Update 2023 MC GT, VtxSmearing, PU library and fix RPC geometry in 2022/2023 MC GTs #42153

Merged

Conversation

saumyaphor4252
Copy link
Contributor

@saumyaphor4252 saumyaphor4252 commented Jun 29, 2023

PR description:

Backport of #42139 and #42265

This PR updates:

In addition

  • All the 2022 and 2023 MC GTs are updated with the RPC geometry fix for the issue in the RPC chambers requested in this CMS Talk post [1].

[1] https://cms-talk.web.cern.ch/t/fix-for-rpc-geometry-for-run3-data-and-mc/25678

GT Differences:

  • See master PRs

PR validation:

GTs tested locally with runTheMatrix.py -l 12034.0,11634.0,7.23,7.24,159.0,159.1,12434.0,160.1,12834.0 -j 8 --ibeos and runTheMatrix.py -l 13734.0 --what upgrade

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #42139 and #42265

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 29, 2023

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for CMSSW_13_1_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor Author

backport of #42139

@saumyaphor4252
Copy link
Contributor Author

test parameters:

  • workflows = 12034.0,11634.0,7.23,7.24,159.0,159.1,12434.0,160.1,12834.0

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8a894/33468/summary.html
COMMIT: 28a6037
CMSSW: CMSSW_13_1_X_2023-06-29-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42153/33468/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 59 lines to the logs
  • Reco comparison results: 3500 differences found in the comparisons
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 3849786
  • DQMHistoTests: Total failures: 6171
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3843593
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
  • Checked 239 log files, 187 edm output root files, 55 DQM output files
  • TriggerResults: found differences in 1 / 53 workflows

@cmsbuild
Copy link
Contributor

Pull request #42153 was updated. @perrotta, @consuegs, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @sunilUIET, @tvami, @francescobrivio can you please check and sign again.

@saumyaphor4252 saumyaphor4252 changed the title [13_1_X] Update RPC geometry fix in 2022, 2023 and 2024 MC GTs [13_1_X] Update 2023 MC GT, VtxSmearing, PU library and fix RPC geometry in 2022/2023 MC GTs Jul 14, 2023
@saumyaphor4252
Copy link
Contributor Author

backport of #42265

@srimanob
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a8a894/33705/summary.html
COMMIT: 3a9c9b1
CMSSW: CMSSW_13_1_X_2023-07-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42153/33705/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • Reco comparison results: 6731 differences found in the comparisons
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 3818977
  • DQMHistoTests: Total failures: 15907
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3803048
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
  • Checked 239 log files, 187 edm output root files, 55 DQM output files
  • TriggerResults: found differences in 2 / 53 workflows

@tvami
Copy link
Contributor

tvami commented Jul 17, 2023

+alca

@srimanob
Copy link
Contributor

+Upgrade

@srimanob
Copy link
Contributor

Kindly ping @cms-sw/pdmv-l2
So that I can make backport of FastSim. Thx.

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

@perrotta @rappoccio ping - can we merge this asap?
It's blocking the 131X backport of #42358 , and AFIU all the other release backports are merged already

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 30ec8ca into cms-sw:CMSSW_13_1_X Jul 26, 2023
@saumyaphor4252 saumyaphor4252 deleted the alca-131X_RPC_geometry_fix branch October 13, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants