Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSC Unpacker fix for handling of rare CSC data corruption #41934

Merged
merged 2 commits into from
Jun 14, 2023
Merged

CSC Unpacker fix for handling of rare CSC data corruption #41934

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01073ac
CSC Unpacker fix for handling of rare data corruption, related to inv…
barvic Jun 12, 2023
316383c
Fixed log messages typos
barvic Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions EventFilter/CSCRawToDigi/src/CSCDDUEventData.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,14 @@ void CSCDDUEventData::unpack_data(const uint16_t* buf, CSCDCCExaminer* examiner)
if (cscid != -1) {
const uint16_t* pos = (const uint16_t*)csc_itr->second;

if (pos == nullptr) {
if (debug)
LogTrace("CSCDDUEventData|CSCRawToDigi")
<< "skip unpacking of CSC " << cscid << " due format errors (NULL pointer to chamber data)"
<< std::dec;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<< "skip unpacking of CSC " << cscid << " due format errors (NULL pointer to chamber data)"
<< std::dec;
<< "skip unpacking of CSC " << cscid << " due to format errors (NULL pointer to chamber data)"
<< std::dec;

Just a small typo. One question: is the idea to print cscid as "hex", and then switch to std::dec ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@missirol thanks! (cut-n-paste legacy typos from other log message few lines below). Fixed both.

continue;
}

ExaminerStatusType errors = examiner->errorsForChamber(cscid);
if ((errors & examiner->getMask()) > 0) {
if (debug)
Expand Down