Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Remove stripTrackerHVOn check for BeamSpotLegacy client #41883

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #41875

Removes the useless check on SiStrip HV status in the BeamSpotLegacy (beam) DQM client - see master PR for further details.

PR validation:

See master PR for validation details

Backport:

Backport of #41875

@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Jun 6, 2023
@francescobrivio
Copy link
Contributor Author

backport of #41875

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2023

A new Pull Request was created by @francescobrivio for CMSSW_13_0_X.

It involves the following packages:

  • DQM/Integration (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@francescobrivio
Copy link
Contributor Author

@cms-sw/dqm-l2 could you please test this backport in the online playback? Thanks a lot!

@emanueleusai
Copy link
Member

Testing at p5

@micsucmed
Copy link

@francescobrivio the PR has been deployed at our Playback systems, could you please check and confirm everything looks ok?

@francescobrivio
Copy link
Contributor Author

@francescobrivio the PR has been deployed at our Playback systems, could you please check and confirm everything looks ok?

Thanks Michel! from the playback log I can see everything is working without crashes.
But in order to see the actual change from this PR we should playback on run 368341 if it's still available - if not, we can relay on the local testing I did (see master PR).

@micsucmed
Copy link

@francescobrivio unfortunately this run isn't available for us anymore, so we must relay on your test. Let me know and I'll create and prepare a production release to change asap

@francescobrivio
Copy link
Contributor Author

@francescobrivio unfortunately this run isn't available for us anymore, so we must relay on your test. Let me know and I'll create and prepare a production release to change asap

I the playback test finished successfully (no crashes), then for me it's +1 to deploy in production at your earliest convenience! Thanks a lot!

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c61437/33007/summary.html
COMMIT: 9b5b5ed
CMSSW: CMSSW_13_0_X_2023-06-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41883/33007/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 227 lines to the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3315916
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3315888
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@syuvivida
Copy link
Contributor

@francescobrivio
we have deployed this PR at the production machine from run 368574.

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jun 7, 2023

+1

@cmsbuild cmsbuild merged commit fd4e993 into cms-sw:CMSSW_13_0_X Jun 7, 2023
@francescobrivio francescobrivio deleted the alca-update_BS_trk_HV_checks_13_0_X branch June 9, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants