Combine DeepTauBase with DeepTauId class

[mbluj]

PR description:

Technical PR which combines the DeepTauBase base class into the DeepTauId class which previously inherited from the base class. This refactoring is to simplify structure of deep-tau code after keeping only one type of deep-tau discriminators. This should be regarded as first step for changes to enable running of deepTauID with SONIC service.

Changes in the code are minor: they consist moving and combining methods of the removed base and DeepTauId classes.

Changes in outputs are not expected.

PR validation:

Custom tests with deepTauID production as well as matrix tests (runTheMatrix.py -l limited -i all --ibeos) passed successfully.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41841/35740

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

• RecoTauTag/RecoTau (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@mbluj, @missirol, @azotz this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[clacaputo]

type tau

[clacaputo]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a52f55/32937/summary.html
COMMIT: 93d4ff2
CMSSW: CMSSW_13_2_X_2023-06-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41841/32937/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 12 lines to the logs
• Reco comparison results: 53 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3221457
• DQMHistoTests: Total failures: 2231
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3219204
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[clacaputo]

There are some reco changes in 12434.7 https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_2_X_2023-06-01-1100+a52f55/57311/validateJR/12434.7_TTbar_14TeV+2023_trackingMkFit/all_RECO_step3/
@mbluj , from you PR's description, it shouldn't be the case

[mbluj]

There are some reco changes in 12434.7 https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_2_X_2023-06-01-1100+a52f55/57311/validateJR/12434.7_TTbar_14TeV+2023_trackingMkFit/all_RECO_step3/ @mbluj , from you PR's description, it shouldn't be the case

This code can only affect output of deepTauId which is produced in miniAOD and/or nanoAOD workflows (+some tau HLT paths), while differences referred here have (most probably) to do with tracking (small differences in pt of pf-charged candidates, in flavours tagges output, etc.). Could it be that results of MkFit are not 100% reproducible (e.g. with different CPU architecture or so)?

[perrotta]

There are some reco changes in 12434.7 https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_2_X_2023-06-01-1100+a52f55/57311/validateJR/12434.7_TTbar_14TeV+2023_trackingMkFit/all_RECO_step3/ @mbluj , from you PR's description, it shouldn't be the case

@cmsbuild non reproducible outputs in that mkfit workflow are showing up from time to time. Here they are clearly unrelated from this PR

[mandrenguyen]

+reconstruction
Code refactoring, no change to reco (diffs are spurious)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@mbluj for a possible further cleanup (in a separate PR):

• reorder alphabetically the included headers, as usual with the ones from cmssw first, and system/external ones after
• make const the static variable varsToDrop at L216, as also suggested by the static analyzer

[perrotta]

+1

[mbluj]

@mbluj for a possible further cleanup (in a separate PR):

• reorder alphabetically the included headers, as usual with the ones from cmssw first, and system/external ones after
• make const the static variable varsToDrop at L216, as also suggested by the static analyzer

@perrotta thank you for suggestions. Do you suggest a technical PR with only small changes addressing those issues (which can be done quickly) or can the fixes wait for other changes in the deepTauID class?

[perrotta]

@perrotta thank you for suggestions. Do you suggest a technical PR with only small changes addressing those issues (which can be done quickly) or can the fixes wait for other changes in the deepTauID class?

It's up to you... Well, if you have another PR ready that touches these classes, you can add them there. Otherwise, it could be more convenient submit a simple PR with the fixes, so that they don't get forgotten.
In any case, there is nothing really urgent to fix there.