Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logical error in the check of mask flag bits [13_0_X] #41832

Merged
merged 2 commits into from
Jun 4, 2023

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented May 31, 2023

PR description:

  1. This PR fixes a bug in the ECAL DQM code which affected the check of status flag bits set on each channel.
    For eg in EnergyTask.cc here and here all other flag bits except kGood and kPoorCalib are being checked when the mask is bitwise inverted, but this is not what was intended.
    The intended behaviour is to check whether kGood or kPoorCalib is set, if not then ignore that channel.
    Similar changes are made in other affected files OccupancyTask.cc and TimingTask.cc

  2. Another small fix is made to change the PU condition in MLClient.cc to ignore the PU=0 runs for the ML inference.

PR validation:

This was validated by running the online DQM workflow and testing the plots on a test DQM GUI.
Also validated by running the runtheMatrix workflow 136.874

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport to 13_0_X, which is currently used in production.
Master PR is : #41830

@cmsbuild
Copy link
Contributor

cmsbuild commented May 31, 2023

A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_13_0_X.

It involves the following packages:

  • DQM/EcalMonitorClient (dqm)
  • DQM/EcalMonitorTasks (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @argiro, @thomreis, @wang0jin this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

type ecal

@cmsbuild cmsbuild added the ecal label May 31, 2023
@emanueleusai
Copy link
Member

backport of #41830

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40488d/32908/summary.html
COMMIT: 77bfa1e
CMSSW: CMSSW_13_0_X_2023-05-31-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41832/32908/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 69 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3315916
  • DQMHistoTests: Total failures: 870
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3315024
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • tested+deployed at p5

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jun 4, 2023

+1

@cmsbuild cmsbuild merged commit 8184016 into cms-sw:CMSSW_13_0_X Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants