-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online DQM configure timeThreshold
appropriately when running in 'offline' mode
#41816
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41816/35703
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
-1 Failed Tests: Build BuildI found compilation error when building: SyntaxError: invalid syntax gmake[1]: *** [config/SCRAM/GMake/Makefile.rules:1927: CompilePython] Error 1 gmake[1]: Target 'PostBuild' not remade because of errors. gmake[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-30-1100' gmake: *** [config/SCRAM/GMake/Makefile.rules:1815: src] Error 2 gmake: Target 'all' not remade because of errors. gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2 + eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-30-1100/tmp/el8_amd64_gcc11/cache/log/src '||' 'true)' ++ scram build outputlog >> Entering Package DQM/Integration |
c5565e8
to
bec2893
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41816/35704
|
Pull request #41816 was updated. @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again. |
@cmsbuild, please test |
bec2893
to
7522c99
Compare
7522c99
to
35fe4f8
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41816/35717
|
Pull request #41816 was updated. @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9999f/32900/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
It was recently realized that when running the Online DQM clients in "offline" mode (e.g. in unit tests or DQM playback) the
timeThreshold
parameter of theOnlineBeamSpotESProducer
was not reset in order to account for the fact that the run played back might have been older than 48h. This PR should fix this behaviour.N.B.: I am assuming that the client is run in
live
mode also when it's run in playback. As I am not sure, this is a RFC.PR validation:
scram b runtests_TestDQMOnlineClient-beam_dqm_sourceclient use-ibeos
runs to completion.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, to be backported to 13.0.X
cc:
@syuvivida @francescobrivio