Fix parameters in PPS RawToDigiConverter, and clean up a few related configs #41784
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41784/35660
|
|
A new Pull Request was created by @perrotta (Andrea Perrotta) for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -52,8 +52,8 @@ | |||
| # various error/warning/info output may be enabled with these flags | |||
| # totemRPRawToDigi.RawUnpacking.verbosity = 1 | |||
| # totemRPRawToDigi.RawToDigi.verbosity = 1 # or higher number for more output | |||
| # totemRPRawToDigi.RawToDigi.printErrorSummary = 1 | |||
| # totemRPRawToDigi.RawToDigi.printUnknownFrameSummary = 1 | |||
| # totemRPRawToDigi.RawToDigi.printErrorSummary = true | |||
| @@ -69,29 +69,27 @@ class RawToDigiConverter { | |||
| TotemVFATStatus status; | |||
| }; | |||
|
|
|||
| unsigned char verbosity; | |||
| const unsigned char verbosity; | |||
There was a problem hiding this comment.
Fantastic! And long-awaited. Could we jump on this opportunity to sanitise a bit the class members and introduce trailing _ to all these?
There was a problem hiding this comment.
Fantastic! And long-awaited. Could we jump on this opportunity to sanitise a bit the class members and introduce trailing
_to all these?
@forthommel feel free to take this commit and adapt it into another more complete PR of yours, if you think so.
Please take into account that there will be that Totem special run in less than one month from now, for which some of that code will need to be backported to 13_0_X (maybe a dedicated release): I would defer too much invasive updates for when those backports will get concluded
perrotta
force-pushed
the
fixParamInCtppsRawToDigiConverter
branch
from
dd3a59a to
80364ca
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41784/35661
|
|
Pull request #41784 was updated. @micsucmed, @nothingface0, @emanueleusai, @clacaputo, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @mandrenguyen, @rvenditti can you please check and sign again. |
|
please test |
perrotta
force-pushed
the
fixParamInCtppsRawToDigiConverter
branch
from
80364ca to
df6bfca
Compare
|
I messed up something... |
|
@forthommel I moved this to #41785: I messed this up this one while playing inadvertently with git during a boring SL shift with no beam.... |
PR description:
Fix a few parameters in PPS RawToDigiConverter:
boolparameters, instead ofunsigned intWhile doing so I also:
This is a follow up of the comment posted when merging PR #41777
PR validation:
It builds and a few matrix workflows run
@oljemark and @cms-sw/ctpps-dpg-l2 please check that this actually corresponds to what you need (nothing should change in the final results with respect to the code currently merged in the master release). I did not try the totemt2_dqm_test because I miss some input: could you please give it a try and report if you get any error from it?