Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MuonHLT@Phase2] Adapt PF Settings in Phase2 MuonHLT #41749

Merged
merged 1 commit into from
May 23, 2023

Conversation

wonpoint4
Copy link

PR description:

This PR is for cleaning duplicated modules in Phase-2 MuonHLT, also following up #40525, #41051.

  • hltParticleFlowClusterHCALForMuons -> hltParticleFlowClusterHCAL
  • hltParticleFlowClusterHBHEForMuons -> hltParticleFlowClusterHBHE
  • hltParticleFlowRecHitHBHEForMuons -> hltParticleFlowRecHitHBHE
  • hltFixedGridRhoFastjetAllCaloForMuons -> hltFixedGridRhoFastjetAllCaloForEGamma

PR validation:

For 100 RelVal TTbar events in CMSSW_13_1_0_pre4, there is no changes of NPassed in paths.

Backport of this PR is not needed.
Tagging HLT Upgrade conveners @beaucero and @SohamBhattacharya

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41749/35616

  • This PR adds an extra 32KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wonpoint4 (Won Jun) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@rchatter, @SohamBhattacharya, @argiro, @Martin-Grunewald, @missirol, @silviodonato, @thomreis, @wang0jin, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-590fa6/32753/summary.html
COMMIT: 76df6b8
CMSSW: CMSSW_13_2_X_2023-05-22-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41749/32753/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221591
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221563
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8cc6f24 into cms-sw:master May 23, 2023
cmsbuild added a commit that referenced this pull request Aug 14, 2023
…2352_131X

Cleanup of HLT Phase-2 menu (#41749, #42351, #42352) [`13_1_X`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants