[12_4_X] WFs to test era Run3_2022_rereco

[sunilUIET]

This PR is to add WFs to run with era Run3_2022_rereco introduced by #41581 which is an urgent PR to validate the new HB thresholds.
This PR has to be validated with #41581.

[cmsbuild]

A new Pull Request was created by @sunilUIET (sunil bansal) for CMSSW_12_4_X.

It involves the following packages:

• Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[sunilUIET]

test parameters:

relvals_opt= -w upgrade
workflows = 14234.0

[sunilUIET]

@cmsbuild please test with #41581

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9c063/32484/summary.html
COMMIT: 9ead4bb
CMSSW: CMSSW_12_4_X_2023-05-08-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41591/32484/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 14234.0

----- Begin Fatal Exception 09-May-2023 06:33:25 CEST-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

[sunilUIET]

test parameters:

relvals_opt= -w upgrade
workflows = 14234.0

[sunilUIET]

@cmsbuild please test with #41581

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9c063/32491/summary.html
COMMIT: 9ead4bb
CMSSW: CMSSW_12_4_X_2023-05-08-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41591/32491/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 14234.0

----- Begin Fatal Exception 09-May-2023 09:06:52 CEST-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

[sunilUIET]

test parameters:

relvals_opt= -w upgrade
workflows = 14034.0

[sunilUIET]

test parameters:

relvals_opt= -w upgrade
workflows = 14034.0

[sunilUIET]

@cmsbuild please test with #41581

[abdoulline]

Just a small comment:
GT auto:phase1_2022_realistic may be suboptimal, as it has very small HCAL pedestals...

I'd think the one with some reasonable HCAL pedestals
'phase1_2022_realistic_postEE' : '124X_mcRun3_2022_realistic_postEE_v1'
would be better...

[abdoulline]

And I suppose eventually some validation/test with 2022E data may be needed (regardless of this WF), as Swagata's PR #41581 is intended for the data re-reco?

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e9c063/32507/summary.html
COMMIT: 5ba9c06
CMSSW: CMSSW_12_4_X_2023-05-08-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41591/32507/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 20 lines to the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3766083
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3766053
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 167 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[sunilUIET]

+pdmv

[AdrianoDee]

+upgrade
Only note: I'd squash the commits (but it's superseded by the urgency).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

[srimanob]

Hi @sunilUIET
Sorry, I am late on comment. This PR introduce a mismatch number of workflow between 12_4 and master, and this should be fixed.

https://github.com/cms-sw/cmssw/blob/CMSSW_12_4_X/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L29-L32

https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L29-L32

[sunilUIET]

Hi @srimanob , This PR is intended only for 12_4_X. Do we need propagate changes to master as well?

[srimanob]

Hi @sunilUIET
Not a change, but a PR to make the workflow ID the same across the release. What you need to work on is the following line:
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L66-L69
But PR in master will be different than 12_4 because if they are in order (by date they are implemented), it will be
2023FS (master, not in 12_4)
2023FSPU (master, not in 12_4)
2022ReReco (12_4, not in master)
2022ReRecoPU (12_4, not in master)
This is to make sure that in future, for any reasons, if we want to bring 2022ReReco to master, we will not screw up the workflow ID.

[tvami]

@sunilUIET what's the master version of this PR?

[sunilUIET]

@tvami As I understood Run3_2022_rereco is included in 12_4_X only so is this PR.

[srimanob]

Here are PRs, that make the workflow ID to be unique,

• (12_4) [12_4] Unique upgrade workflow ID #41688
• (13_2) [13_2] Unique upgrade workflow ID #41689
• (13_1) to come

I would like to make sure that we always keep unique IDs for upgrade workflows across the release.