Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_0_X] Add correct L1TCaloParams in 130X 2022 HI MC GT #41567

Conversation

francescobrivio
Copy link
Contributor

PR description:

Prompted by this comment and following the official request in this CMSTalk post, this PR updates the 2022 130X HI MC GT with the correct L1TCaloParams tag: L1TCaloParams_static_HI_2022_v0_05_mc_v1.

This PR is a backport of #41437 and complements the other 13_0_X backport #41440.

GT difference:

PR validation:

Successfully run: runTheMatrix.py -l 312.0 -j 8 --ibeos

Backport:

Backport of #41437

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2023

A new Pull Request was created by @francescobrivio for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58dbf9/32433/summary.html
COMMIT: 161097f
CMSSW: CMSSW_13_0_X_2023-05-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41567/32433/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 14 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554764
  • DQMHistoTests: Total failures: 68
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554674
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented May 6, 2023

Just checking: no update to the 2023 HI GT?

@saumyaphor4252
Copy link
Contributor

Just checking: no update to the 2023 HI GT?

For the 2023 HI GT, the update was done at #41440.

@tvami
Copy link
Contributor

tvami commented May 8, 2023

+alca

  • diffs in HI wf, as expected

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4f7bce9 into cms-sw:CMSSW_13_0_X May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants