Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renew matched lepton ids for every jet #41407

Merged
merged 1 commit into from
May 2, 2023
Merged

renew matched lepton ids for every jet #41407

merged 1 commit into from
May 2, 2023

Conversation

menglu21
Copy link
Contributor

@menglu21 menglu21 commented Apr 26, 2023

PR description:

< initially the matched lepton ids are declared only once https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/plugins/LeptonInJetProducer.cc#L79-L80, in the case of that when there is no matched lepton, the previous matched lepton id will be used for the next jet, i.e., two fat jets can match to one lepton which is not correct. >

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of PR #41325

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2023

A new Pull Request was created by @menglu21 (Meng_Lu) for CMSSW_13_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

backport of #41325

@perrotta
Copy link
Contributor

type bugfix

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9f92ec/32148/summary.html
COMMIT: 58b1293
CMSSW: CMSSW_13_0_X_2023-04-25-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41407/32148/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 13 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554298
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554264
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

@cms-sw/xpog-l2 this seems a quite logic and simple fix, and its master version is merged since a while already.
In case you want it in 13_0_X a signature from yours is requested...
(There are also quite several other PRs already merged in master which only miss the XPOG signature: even for them, that missing signature is the only reason why they are not yet merged in the 2023 data taking release)

@simonepigazzini
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented May 2, 2023

+1

@cmsbuild cmsbuild merged commit 2f74d7f into cms-sw:CMSSW_13_0_X May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants