Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vertexing monitoring for Tracker Alignment AlCaReco samples #41378

Merged
merged 3 commits into from
Apr 25, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 20, 2023

PR description:

The goal of this PR is to a generic vertex analyzer to be used for the Tracker Alignment alcareco monitoring.
I profit of this PR to add some more histograms concerning the Beam Spot monitoring to an existing analyzer and to improve the unit test suite.

PR validation:

Run successfully the augmented unit tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41378/35241

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Alignment/OfflineValidation (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Apr 20, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ada15/32070/summary.html
COMMIT: 3d4fbc6
CMSSW: CMSSW_13_1_X_2023-04-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41378/32070/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3459877
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3459852
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Apr 24, 2023

@cms-sw/alca-l2 any comment on this PR?

@tvami
Copy link
Contributor

tvami commented Apr 24, 2023

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Apr 24, 2023

would it make sense to backport this?

@mmusich
Copy link
Contributor Author

mmusich commented Apr 24, 2023

would it make sense to backport this?

yes, I am waiting to have it merged.

@tvami
Copy link
Contributor

tvami commented Apr 25, 2023

urgent

  • given that this PRs backport is relevant for data taking monitoring, I think it makes sense to have this urgent

@perrotta
Copy link
Contributor

+1

@mmusich
Copy link
Contributor Author

mmusich commented Apr 26, 2023

given that this PRs backport is relevant for data taking monitoring, I think it makes sense to have this urgent

the backport of this is at #41408. I lumped there #41393 since it's affecting the same package to avoid opening too many PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants