add GPU RelVals using 2023 HLT menu (+2023 Patatrack NoPU wfs) [`13_0_X`] #41371

missirol · 2023-04-18T18:42:31Z

backport of #41354
partial backport of #40847

PR description:

This PR is a backport #41354, plus a partial backport of #40847. The latter added Patatrack wfs with 2023 conditions in CMSSW_13_1_X.

From the description of #41354:

This PR is an attempt to add GPU RelVals making use of the 2023 HLT menu. The goal is to have wfs that run the latest HLT pp menu for 2023 on machines with a GPU.

Workflows are added for both MC and data (using data from 2022), trying to follow the structure of the existing GPU RelVals.

The next step would be to change the default GPU wfs in PR tests (here) to use 2023 ones.

PR validation:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#41354
#40847 (partial)

To aid development of HLT menus for 2023 data taking.

cmsbuild · 2023-04-18T18:42:59Z

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_0_X.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo, @kpedro88 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Backported from add GPU RelVals using 2023 HLT menu #41354

missirol · 2023-04-18T18:43:11Z

test parameters:

enable = gpu
workflows_gpu = 12450.502,12450.503,12450.504,12450.506,12450.507,12450.508,12434.502,12434.503,12434.504,12434.506,12434.507,12434.508,12434.512,12434.513,12434.514,12434.522,12434.523,12434.524,12434.582,12434.583,12434.586,12434.587,12434.592,12434.593,12434.596,12434.597,140.065506,140.065512,140.065522
workflows = 140.065505,140.065511,140.065521

missirol · 2023-04-18T18:43:24Z

please test

cmsbuild · 2023-04-18T21:20:37Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1f414/32025/summary.html
COMMIT: dc10891
CMSSW: CMSSW_13_0_X_2023-04-18-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41371/32025/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 6 lines from the logs
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3554298
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3554272
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19862
DQMHistoTests: Total failures: 455
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19407
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

sunilUIET · 2023-04-19T10:05:45Z

+pdmv

missirol · 2023-04-21T07:36:31Z

@srimanob , can you please sign this backport as well ? (the PR to master is fully signed)

srimanob · 2023-04-21T08:04:47Z

+Upgrade

cmsbuild · 2023-04-21T08:05:15Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2023-04-27T15:11:40Z

Pull request #41371 was updated. @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please check and sign again.

missirol · 2023-04-27T15:11:53Z

test parameters:

enable = gpu
workflows_gpu = 12450.502,12450.503,12450.504,12450.506,12450.507,12450.508,12434.502,12434.503,12434.504,12434.506,12434.507,12434.508,12434.512,12434.513,12434.514,12434.522,12434.523,12434.524,12434.582,12434.583,12434.586,12434.587,12434.592,12434.593,12434.596,12434.597,140.065506,140.065512,140.065522
workflows = 140.065505,140.065511,140.065521

missirol · 2023-04-27T15:12:23Z

please test

The latest push reverts the backport of #41386 (re-including 12450.* wfs from GPU_X IBs).

cmsbuild · 2023-04-27T17:42:40Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1f414/32205/summary.html
COMMIT: 53a7b68
CMSSW: CMSSW_13_0_X_2023-04-27-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41371/32205/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3554298
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3554267
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19862
DQMHistoTests: Total failures: 457
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19405
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

missirol · 2023-04-28T07:45:31Z

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 , could you please re-sign? Thanks!

kskovpen · 2023-04-28T07:47:51Z

+pdmv

AdrianoDee · 2023-04-28T18:00:25Z

+upgrade
(basically just a resign)

cmsbuild · 2023-04-28T18:00:53Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-04-28T19:13:12Z

+1

cmsbuild added this to the CMSSW_13_0_X milestone Apr 18, 2023

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending backport upgrade-pending labels Apr 18, 2023

cmsbuild added tests-started and removed tests-pending labels Apr 18, 2023

missirol mentioned this pull request Apr 18, 2023

add GPU RelVals using 2023 HLT menu #41354

Merged

cmsbuild added tests-approved and removed tests-started labels Apr 18, 2023

cmsbuild added pdmv-approved and removed pdmv-pending labels Apr 19, 2023

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Apr 21, 2023

cmsbuild added backport-ok and removed backport labels Apr 21, 2023

missirol mentioned this pull request Apr 22, 2023

Remove 12450.* wfs (2023, ZMuMu) from GPU RelVals #41386

Closed

missirol force-pushed the devel_wfGPU2023_130X branch from dc10891 to 08ce527 Compare April 22, 2023 15:18

cmsbuild added tests-approved and removed tests-started labels Apr 22, 2023

add GPU RelVals using 2023 HLT menu (+2023 Patatrack NoPU wfs)

53a7b68

missirol force-pushed the devel_wfGPU2023_130X branch from 08ce527 to 53a7b68 Compare April 27, 2023 15:11

cmsbuild added tests-pending and removed tests-approved labels Apr 27, 2023

cmsbuild added tests-started and removed tests-pending labels Apr 27, 2023

cmsbuild added tests-approved and removed tests-started labels Apr 27, 2023

cmsbuild added pdmv-approved and removed pdmv-pending labels Apr 28, 2023

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Apr 28, 2023

cmsbuild added orp-approved and removed orp-pending labels Apr 28, 2023

cmsbuild merged commit e0bef16 into cms-sw:CMSSW_13_0_X Apr 28, 2023

missirol mentioned this pull request May 2, 2023

Change default wfs for PR tests on GPU in CMSSW_13_X_Y cms-sw/cms-bot#1976

Closed

missirol deleted the devel_wfGPU2023_130X branch January 19, 2024 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add GPU RelVals using 2023 HLT menu (+2023 Patatrack NoPU wfs) [`13_0_X`] #41371

add GPU RelVals using 2023 HLT menu (+2023 Patatrack NoPU wfs) [`13_0_X`] #41371

missirol commented Apr 18, 2023 •

edited

Loading

cmsbuild commented Apr 18, 2023 •

edited

Loading

missirol commented Apr 18, 2023

missirol commented Apr 18, 2023

cmsbuild commented Apr 18, 2023

sunilUIET commented Apr 19, 2023

missirol commented Apr 21, 2023

srimanob commented Apr 21, 2023

cmsbuild commented Apr 21, 2023

cmsbuild commented Apr 27, 2023

missirol commented Apr 27, 2023

missirol commented Apr 27, 2023

cmsbuild commented Apr 27, 2023

missirol commented Apr 28, 2023

kskovpen commented Apr 28, 2023

AdrianoDee commented Apr 28, 2023

cmsbuild commented Apr 28, 2023

rappoccio commented Apr 28, 2023

add GPU RelVals using 2023 HLT menu (+2023 Patatrack NoPU wfs) [13_0_X] #41371

add GPU RelVals using 2023 HLT menu (+2023 Patatrack NoPU wfs) [13_0_X] #41371

Conversation

missirol commented Apr 18, 2023 • edited Loading

PR description:

PR validation:

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

cmsbuild commented Apr 18, 2023 • edited Loading

missirol commented Apr 18, 2023

missirol commented Apr 18, 2023

cmsbuild commented Apr 18, 2023

Comparison Summary

GPU Comparison Summary

sunilUIET commented Apr 19, 2023

missirol commented Apr 21, 2023

srimanob commented Apr 21, 2023

cmsbuild commented Apr 21, 2023

cmsbuild commented Apr 27, 2023

missirol commented Apr 27, 2023

missirol commented Apr 27, 2023

cmsbuild commented Apr 27, 2023

Comparison Summary

GPU Comparison Summary

missirol commented Apr 28, 2023

kskovpen commented Apr 28, 2023

AdrianoDee commented Apr 28, 2023

cmsbuild commented Apr 28, 2023

rappoccio commented Apr 28, 2023

add GPU RelVals using 2023 HLT menu (+2023 Patatrack NoPU wfs) [`13_0_X`] #41371

add GPU RelVals using 2023 HLT menu (+2023 Patatrack NoPU wfs) [`13_0_X`] #41371

missirol commented Apr 18, 2023 •

edited

Loading

cmsbuild commented Apr 18, 2023 •

edited

Loading