Catch and rethrow xml exceptions in TotemDAQMappingESSourceXML

[Dr15Jones]

PR description:

The exceptions are converted to cms::Exceptions.
Unknown exceptions were seen from this code in the IBs.

PR validation:

Code compiles.

[Dr15Jones]

@makortel FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41329/35156

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• CalibPPS/ESProducers (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @fabferro, @mmusich, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[grzanka]

@Dr15Jones You wrote that Unknown exceptions were seen from this code in the IBs. Can you elaborate a bit more on what exactly has happen ? Is it a sign that the XML files were not parsed correctly ?

[Dr15Jones]

The failure was seen in

https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el9_aarch64_gcc11/CMSSW_13_1_X_2023-04-11-2300/unitTestLogs/Calibration/PPSAlCaRecoProducer#/

with the only error message being

----- Begin Fatal Exception 12-Apr-2023 04:26:00 CEST-----------------------
An exception of category 'Unknown' occurred while
   [0] Processing  Event run: 322022 lumi: 1025 event: 1759844338 stream: 0
   [1] Running path 'ALCARECOoutput_step'
   [2] Prefetching for module PoolOutputModule/'ALCARECOoutput'
   [3] Prefetching for module TotemVFATRawToDigi/'totemTimingRawToDigiAlCaRecoProducer'
   [4] Calling method for EventSetup module TotemDAQMappingESSourceXML/'totemDAQMappingESSourceXML_TotemTiming'
Exception Message:
An exception of unknown type was thrown.
----- End Fatal Exception -------------------------------------------------

The reason I made this PR is so we could actually see the error message.

[grzanka]

The failure was seen in

https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el9_aarch64_gcc11/CMSSW_13_1_X_2023-04-11-2300/unitTestLogs/Calibration/PPSAlCaRecoProducer#/

with the only error message being

----- Begin Fatal Exception 12-Apr-2023 04:26:00 CEST-----------------------
An exception of category 'Unknown' occurred while
   [0] Processing  Event run: 322022 lumi: 1025 event: 1759844338 stream: 0
   [1] Running path 'ALCARECOoutput_step'
   [2] Prefetching for module PoolOutputModule/'ALCARECOoutput'
   [3] Prefetching for module TotemVFATRawToDigi/'totemTimingRawToDigiAlCaRecoProducer'
   [4] Calling method for EventSetup module TotemDAQMappingESSourceXML/'totemDAQMappingESSourceXML_TotemTiming'
Exception Message:
An exception of unknown type was thrown.
----- End Fatal Exception -------------------------------------------------

The reason I made this PR is so we could actually see the error message.

Its interesting, am I correct the error seems to appear only in last IB and only for specific architecture (fails on aarch64, works on amd64) ?

[iarspider]

Its interesting, am I correct the error seems to appear only in last IB and only for specific architecture (fails on aarch64, works on amd64) ?

Yes, only in the latest IB, only for aarch64. And I have tried reproducing the failure locally, but could not.

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47f670/31953/summary.html
COMMIT: 0069f22
CMSSW: CMSSW_13_1_X_2023-04-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41329/31953/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially added 25 lines to the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3459609
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3459578
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47f670/31958/summary.html
COMMIT: 0069f22
CMSSW: CMSSW_13_1_X_2023-04-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41329/31958/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3459609
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3459578
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tvami]

@cmsbuild , please test for el9_aarch64_gcc11

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47f670/31959/summary.html
COMMIT: 0069f22
CMSSW: CMSSW_13_1_X_2023-04-11-2300/el9_aarch64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41329/31959/install.sh to create a dev area with all the needed externals and cmssw changes.

[tvami]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1