Fixing the missing Tau plots within the L1T offline DQM

[vukasinmilosevic]

PR description:

Updating the L1T Tau offline DQM modules to take into account changes in inputs that were causing the plots to be empty:

• This setup was facing the same issue as previously reported for the L1T Muon offline DQM - some HLT modules are listed behind hltBoolEnd, breaking the currently implemented logic for matching to HLT objects (more details in PR Fix trigger matching issues in L1Trigger DQMOffline #39691)
• Offline Tau experts have removed the anti-electron discriminators that are used as input to the Tau DQM code. Implemented a quick fix so that they are simply removed from the offline tau requirements if they do not exist.
• Added more details to warning messages regarding the non-existence of tau discriminators.

PR validation:

Validated using a Run 3 VBFHToTauTau sample, using the following workflow:

cmsDriver.py step2 --conditions 124X_mcRun3_2022_realistic_postEE_v1 --mc --datatier RECO,DQMIO --era Run3 --eventcontent RECO,DQM --filein root://cms-xrd-global.cern.ch//store[/store/mc/Run3Summer22EEDR/VBFHToTauTau_M125_TuneCP5_13p6TeV_powheg-pythia8/GEN-SIM-RAW/Poisson70KeepRAW_124X_mcRun3_2022_realistic_postEE_v1-v2/2820000/017d5531-802d-448b-8619-5371edb0620d.root](https://cmsweb.cern.ch/das/request?input=file%3D%2Fstore%2Fmc%2FRun3Summer22EEDR%2FVBFHToTauTau_M125_TuneCP5_13p6TeV_powheg-pythia8%2FGEN-SIM-RAW%2FPoisson70KeepRAW_124X_mcRun3_2022_realistic_postEE_v1-v2%2F2820000%2F017d5531-802d-448b-8619-5371edb0620d.root&instance=prod/global) --fileout file:step2.root --nStreams 2 --nThreads 8 --no_exec --number 10 --process RECO --python_filename step_2L1T_cfg.py --scenario pp --step RAW2DIGI,L1Reco,RECO,DQM:@L1TMuon

cmsDriver.py step3 --conditions 124X_dataRun3_Prompt_v4 --data --era Run3 --filein file:step2_inDQM.root --fileout file:step3.root --filetype DQM --nStreams 2 --no_exec --number 10 --python_filename step_3_cfg.py --scenario pp --step HARVESTING:DQMHarvestL1TMuon

cmsRun step_2L1T_cfg.py
cmsRun step_3_cfg.py

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41170/34846

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41170/34846/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41170/34846/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41170/34854

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @vukasinmilosevic (Vukasin Milosevic) for master.

It involves the following packages:

• DQMOffline/L1Trigger (dqm, l1)

@aloeliger, @epalencia, @emanueleusai, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@missirol, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41170/34857

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #41170 was updated. @aloeliger, @epalencia, @emanueleusai, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please check and sign again.

[cmsbuild]

Pull request #41170 was updated. @aloeliger, @epalencia, @emanueleusai, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please check and sign again.

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c40314/31585/summary.html
COMMIT: 6d86281
CMSSW: CMSSW_13_1_X_2023-03-24-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41170/31585/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3554286
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3554257
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[aloeliger]

@vukasinmilosevic Actually, I'm getting ahead of myself here. I'm not sure I see the change/fix in the DQM comparison plots. Do you have examples of the now non-empty DQM plots for taus?

[vukasinmilosevic]

Hi, you can check here: /afs/cern.ch/user/v/vmilosev/public/DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root
In oder to get this output, I run over 12k VBFHToTauTau events.

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

+1

[perrotta]

ping bot