Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for (py3-)torch #41162

Merged
merged 10 commits into from
Jan 8, 2024
Merged

Add test for (py3-)torch #41162

merged 10 commits into from
Jan 8, 2024

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Mar 23, 2023

This PR was made to check the build of (py-)torch. We should only merge it if CMS-ML group really want to make use of this external otherwise it will increase the maintenance for external software stack ( as it has a large dependency chain https://github.com/cms-sw/cmsdist/pull/8388/files#diff-1718ab1f6737a0d8faffa3b2914ec2f72b87d478b4e3db04828411d2878479a1R11 )

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41162/34819

  • This PR adds an extra 16KB to repository

  • Found files with invalid states:

    • PhysicsTools/PythonAnalysis/test/test_torch_gpu.py:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41162/34820

  • This PR adds an extra 16KB to repository

  • Found files with invalid states:

    • PhysicsTools/PythonAnalysis/test/test_torch_gpu.py:

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 23, 2023

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • PhysicsTools/PythonAnalysis (analysis)

@cmsbuild can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

test parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2023

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41162/35006

  • This PR adds an extra 16KB to repository

  • Found files with invalid states:

    • PhysicsTools/PythonAnalysis/test/test_torch_gpu.py:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41162/35007

  • This PR adds an extra 16KB to repository

  • Found files with invalid states:

    • PhysicsTools/PythonAnalysis/test/test_torch_gpu.py:

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2023

Pull request #41162 was updated. @cmsbuild can you please check and sign again.

@iarspider
Copy link
Contributor Author

test parameters:

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41162/37969

  • This PR adds an extra 20KB to repository

  • Found files with invalid states:

    • PhysicsTools/PythonAnalysis/test/test_torch.py:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41162/37972

  • This PR adds an extra 24KB to repository

  • Found files with invalid states:

    • PhysicsTools/PythonAnalysis/test/test_torch.py:

@cmsbuild
Copy link
Contributor

Pull request #41162 was updated. @cmsbuild, @tvami can you please check and sign again.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1bdff3/36190/summary.html
COMMIT: db19114
CMSSW: CMSSW_14_0_X_2023-11-29-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41162/36190/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1bdff3/36190/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1bdff3/36190/git-merge-result

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • You potentially added 58 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 1
  • DQMHistoTests: Total histograms compared: 0
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 0
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 6 log files, 4 edm output root files, 1 DQM output files

@tvami
Copy link
Contributor

tvami commented Dec 19, 2023

+analysis

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c2bbc23 into cms-sw:master Jan 8, 2024
15 checks passed
@iarspider iarspider deleted the torch-tests branch February 27, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants