Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PPS][NanoAOD] Generator-level proton information [10_6_X] #40922

Closed

Conversation

michael-pitt
Copy link
Contributor

PR description:

This is a backport of #36080 developed by @forthommel, with a few modifications to run in 10_6_X.

PR validation:

Tested with 10_6_32_patch1

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

The backport is needed to allow GenProtons in nanoAOD produced with 10_6_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

A new Pull Request was created by @michael-pitt (Michael Pitt) for CMSSW_10_6_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@michael-pitt michael-pitt changed the title backport [PPS][NanoAOD] Generator-level proton information [10_6_X] Mar 2, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

Pull request #40922 was updated. @cmsbuild, @swertz, @vlimant can you please check and sign again.

@swertz
Copy link
Contributor

swertz commented Mar 2, 2023

Hi @michael-pitt @forthommel , I'm afraid we cannot allow to modifying ongoing (Nano) productions campaigns... This would make previous and future NanoAODv9 samples in 10_6_X inconsistent.

Having this for Run2 MC would be an argument for re-Nano of Run2 samples at a later point, but this would happen in a more recent release (13_X_Y) and as Nano vX with X>=12...

@michael-pitt
Copy link
Contributor Author

Hi @swertz

We don't plan to modify the current campaign. If the V9 campaign is produced with 10_6_AA and 10_6_BB, then we would like to update the 10_6_CC, where CC != AA nor BB. This is for Run2 nanoAODs produced privately. Any suggestion on how to resolve this issue is welcomed. For example, having a dedicated cff that can be used for private production or maintaining a patch with this update.

Regards,
Michael

@swertz
Copy link
Contributor

swertz commented Mar 6, 2023

We don't plan to modify the current campaign. If the V9 campaign is produced with 10_6_AA and 10_6_BB, then we would like to update the 10_6_CC, where CC != AA nor BB.

Unfortunately that's not how things work... The ongoing campains runs in 10_6_X and sometimes moves to a newer X to pick up bug fixes. So, there's no guarantee that it will not switch to CC at some point.

This is for Run2 nanoAODs produced privately. Any suggestion on how to resolve this issue is welcomed. For example, having a dedicated cff that can be used for private production or maintaining a patch with this update.

Yes, in that case, having the code in the release but inactive by default, to be simply enabled for private productions, is perfectly fine.

@perrotta
Copy link
Contributor

perrotta commented Apr 5, 2023

backport of #36080

@vlimant
Copy link
Contributor

vlimant commented Mar 29, 2024

please close

@cmsbuild cmsbuild closed this Mar 29, 2024
@cmsbuild
Copy link
Contributor

cms-bot internal usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants