-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport FastSim refiner network for NANO (DeepJet for AK4 CHS Jets) #40828
Conversation
…FastSim NANO collections
A new Pull Request was created by @sbein (Sam Bein) for CMSSW_10_6_X. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
Hi @sbein , could you please also add the new refined variables to the nanoDQM, for the fastsim modifier, here: https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/nanoDQM_cff.py |
…efined variables will carry the normal names in NANO.
b324500
to
64d138d
Compare
Pull request #40828 was updated. @cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please check and sign again. |
@swertz, I've updated the last commit to implement the chosen naming scheme https://github.com/cms-sw/cmssw/pull/40828/files#diff-377770d6a7d4705da48aa96709bdedefcb42d5b5497c85ba41a3f11074c148a0R541-R560. For reference, we decided to assign the refined variables to take the normal variable names in NANO, and for now preserve the original values as new variables with suffix "unrefined". This will not complicate ongoing campaigns because the refinement will only be triggered by the cmsDriver customize function in the NANO step. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce01b2/30923/summary.html Comparison SummarySummary:
|
+1 No differences in existing workflows as expected. |
+1 |
@kpedro88 , though it is possible but will consume few github api calls per extra PR which I would like to avoid. As this type of updates are not frequent any way :-) |
@cmsbuild please test workflow 135.14 Re-test after 3 weeks. |
@sbein Do I understand correctly that we still need this PR? Thx. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ce01b2/33176/summary.html Comparison SummarySummary:
|
@srimanob yes we do. It should be merged, thanks! +1 |
+Upgrade |
Kindly ping @cms-sw/xpog-l2 @cms-sw/pdmv-l2 |
+pdmv |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Tag for Update tag for PhysicsTools-NanoAOD to V01-01-00-01-00 Needed by cms-sw/cmssw#40828 (already merged)
PR description:
The main thing here is to backport the FastSim refinement network applied as part of the NANO step (#40553). This feature modifies AK4 CHS jets relevant for Run 2 UltraLegacy MC (NANOv9 and greater). This BP is different from the original PR in that the default meanings of the DeepJet observables don't change, and a new separate set of variables are added to NANO with suffix
refined
. A cms-data backport will also accompany this PR to support https://github.com/sbein/cmssw/blob/b32450010a0ed20cf00cfc9ba2e5626d329f1f5a/PhysicsTools/NanoAOD/python/jets_cff.py#L555.This PR backports the ONNX RunTime library additions, 3152213, as they are needed to run the refinement network. This in turn requires a couple of restructuring changes implemented here in order for PhysicsTools/NanoAOD to not trip on changes in the PhysicsTools/PatAlgos/plugins buildfile.
The following commands were used to test the workflow
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 10 --era Run2_2016 --eventcontent FEVTDEBUGHLT,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION:@standardValidation,DQM:@standardDQM --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic25ns13TeV2016Collision
cmsDriver.py step3 --conditions auto:run2_mc --fast -n 100 --era Run2_2016 --eventcontent MINIAODSIM --runUnscheduled --filein file:step1.root -s PAT --datatier MINIAODSIM --mc
cmsDriver.py step4 --conditions auto:run2_mc --fast -n 1000 --era Run2_2016 --eventcontent NANOAODSIM --filein file:step3_PAT.root -s NANO --datatier NANOAODSIM --customise PhysicsTools/NanoAOD/jets_cff.nanoAOD_refineFastSim_bTagDeepFlav --mc