Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_0_X (2/N) [13_1_X] #40790

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_13_0_X.

This is the PR for the master branch, which will then be backported to 13_0_X (the latter is the release cycle currently used for Run-3 HLT-menu development).

This PR includes the integration of the following JIRA tickets.

  • CMSHLT-2592: [TSG] removal of deprecated GRun Paths post Run2022 (combined table unchanged)
  • CMSHLT-2593: [TSG] remove unused Paths from HLT combined menu (post Run2022)
  • CMSHLT-2596: [TSG] split EGamma,JetMET,Muon datasets and streams by 2
  • CMSHLT-2605: [GEM] extend RPCMON stream to GEM
  • CMSHLT-2607: [PPS] extend list of CT-PPS FEDs
  • CMSHLT-2613: [EGM] added two MC_Egamma_Open Paths (only to combined table)
  • CMSHLT-2633: [EXO] update of displaced Photon+PFHT trigger and addition of backups

It also includes the migration of the HLT menus ("Fake*", frozen, and development ones) to the ConfDB template for CMSSW_13_0_0_pre4.

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_13_0_X

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40790/34219

  • This PR adds an extra 812KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

enable gpu

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7852c6/30671/summary.html
COMMIT: 45d5080
CMSSW: CMSSW_13_1_X_2023-02-16-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40790/30671/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially added 19 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 54 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3523922
  • DQMHistoTests: Total failures: 1184
  • DQMHistoTests: Total nulls: 84
  • DQMHistoTests: Total successes: 3522632
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -93310.84 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -9818.210 KiB HLT/BTV
  • DQMHistoSizes: changed ( 11634.0,... ): -1531.818 KiB HLT/EXO
  • DQMHistoSizes: changed ( 11634.0,... ): -1187.008 KiB HLT/TOP
  • DQMHistoSizes: changed ( 11634.0,... ): -1130.035 KiB HLT/HIG
  • DQMHistoSizes: changed ( 11634.0,... ): -474.491 KiB HLT/JME
  • DQMHistoSizes: changed ( 11634.0,... ): -274.408 KiB HLT/Objects
  • DQMHistoSizes: changed ( 11634.0,... ): -152.027 KiB HLT/TAU
  • DQMHistoSizes: changed ( 11634.0,... ): -117.172 KiB HLT/EGM
  • DQMHistoSizes: changed ( 11634.0,... ): -55.156 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): 37.609 KiB HLT/Filters
  • DQMHistoSizes: changed ( 11634.0 ): ...
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 47 workflows

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 21 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19862
  • DQMHistoTests: Total failures: 65
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19797
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 3 / 3 workflows

@missirol
Copy link
Contributor Author

please test

The RelVals-INPUT error in #40791 is not a time-out. It's probably transient and unrelated to these HLT changes, but to be extra-safe the tests are restarted.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7852c6/30685/summary.html
COMMIT: 45d5080
CMSSW: CMSSW_13_1_X_2023-02-16-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40790/30685/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 50 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3523922
  • DQMHistoTests: Total failures: 1178
  • DQMHistoTests: Total nulls: 84
  • DQMHistoTests: Total successes: 3522638
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -93310.84 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -9818.210 KiB HLT/BTV
  • DQMHistoSizes: changed ( 11634.0,... ): -1531.818 KiB HLT/EXO
  • DQMHistoSizes: changed ( 11634.0,... ): -1187.008 KiB HLT/TOP
  • DQMHistoSizes: changed ( 11634.0,... ): -1130.035 KiB HLT/HIG
  • DQMHistoSizes: changed ( 11634.0,... ): -474.491 KiB HLT/JME
  • DQMHistoSizes: changed ( 11634.0,... ): -274.408 KiB HLT/Objects
  • DQMHistoSizes: changed ( 11634.0,... ): -152.027 KiB HLT/TAU
  • DQMHistoSizes: changed ( 11634.0,... ): -117.172 KiB HLT/EGM
  • DQMHistoSizes: changed ( 11634.0,... ): -55.156 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): 37.609 KiB HLT/Filters
  • DQMHistoSizes: changed ( 11634.0 ): ...
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 47 workflows

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 30 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19862
  • DQMHistoTests: Total failures: 244
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19618
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 3 / 3 workflows

@missirol
Copy link
Contributor Author

+hlt

  • changes in the outputs of PR tests are in line with updates to the HLT GRun menu, and the change in name of the frozen/fake HLT menus

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3a272a9 into cms-sw:master Feb 17, 2023
@missirol missirol deleted the HLTdevelopment130X_for131X branch February 17, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants