[QGL, JMENanoAOD] PUPPI-compatible QGTagger producer #40667

nurfikri89 · 2023-02-02T08:28:42Z

PR description:

The main goal of this PR is to modify QGTagger producer (used to compute Quark-Gluon (QG) Likelihood) so that it is compatible with PUPPI jets. The QGTagger calculates three input variables, used to compute the likelihood, from PF constituents of jets. The changes in this PR allows the QGTagger to compute the input variables with PUPPI weights applied on the PF constituents by accessing the weights from the provided ValueMap<float>. This can also be done for any constituents weights, not just PUPPI. Additionally, this PR makes it optional to not compute the likelihood and calculate just the three input variables for users who wants only them.

With these modifications of the QGTagger, it should not affect CHS jets so we do not expect to see any change to the output of workflows. The QGTagger is currently scheduled to run only for AK4 CHS jets at the MiniAOD and (Run-2) NanoAOD production level.

Other changes:

some fixes for JMENanoAOD.
fine-tune histograms in nanoDQM for JMENano.

PR validation:

Validation plots comparing the input variables before and after the fix can be found in this JMAR meeting contribution.
passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos
passes reMiniAOD and reNanoAOD workflows: runTheMatrix.py -i all --ibeos -l 1325.518,2500.312
passes the JMENano workflows: runTheMatrix.py -i all --ibeos -l 10224.15,11024.15,25202.15,11634.15

…e likelihood

… score for training to fix bug for btagDeepCvL. Fix isPUPPIJet bug for PileUpJetID. Fix name for ParticleNet gluon score.

cmsbuild · 2023-02-02T08:38:06Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40667/34011

This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40667/34011/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40667/34011/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40667/34011/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40667/34011/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2023-02-02T09:13:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40667/34012

This PR adds an extra 32KB to repository

cmsbuild · 2023-02-02T09:13:44Z

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)
RecoJets/JetProducers (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @yslai, @missirol, @jdamgov, @ahinzmann, @nhanvtran, @gkasieczka, @clelange, @schoef, @gpetruc, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

swertz · 2023-02-02T10:29:54Z

enable nano

swertz · 2023-02-02T10:30:03Z

please test

cmsbuild · 2023-02-02T14:49:32Z

-1

Failed Tests: HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4b9fd/30353/summary.html
COMMIT: deb78e8
CMSSW: CMSSW_13_0_X_2023-02-01-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40667/30353/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 4 lines to the logs
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555495
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555467
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 7 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 10829
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 10829
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.232	2.232	0.000 ( +0.0% )	9.66	9.07	+6.5%	1.564	1.530
2500.311	2.323	2.323	0.000 ( +0.0% )	9.35	8.73	+7.1%	1.921	1.902
2500.312	2.277	2.277	0.000 ( +0.0% )	9.51	8.81	+8.0%	1.926	1.896
2500.33	1.098	1.098	0.000 ( +0.0% )	21.90	19.08	+14.8%	1.659	1.640
2500.331	1.393	1.393	0.000 ( +0.0% )	16.13	14.58	+10.7%	1.815	1.796
2500.332	1.324	1.324	0.000 ( +0.0% )	18.11	16.25	+11.5%	1.833	1.829
2500.401	2.138	2.138	0.000 ( +0.0% )	10.05	10.45	-3.9%	1.234	1.223
2500.501	1.711	1.711	0.000 ( +0.0% )	16.22	16.67	-2.7%	1.148	1.142
2500.511	1.123	1.123	0.000 ( +0.0% )	30.97	31.26	-0.9%	1.402	1.397
2500.601	2.050	2.050	0.000 ( +0.0% )	12.24	12.53	-2.3%	1.207	1.207

swertz · 2023-02-07T17:17:50Z

please test

cmsbuild · 2023-02-07T20:00:59Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4b9fd/30470/summary.html
COMMIT: ecca70a
CMSSW: CMSSW_13_0_X_2023-02-07-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40667/30470/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 13 lines from the logs
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555852
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555827
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 2 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 10829
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 10829
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.232	2.232	0.000 ( +0.0% )	9.70	9.41	+3.1%	1.452	1.506
2500.311	2.323	2.323	0.000 ( +0.0% )	9.33	9.26	+0.7%	1.822	1.873
2500.312	2.277	2.277	0.000 ( +0.0% )	9.41	9.33	+0.8%	1.807	1.873
2500.33	1.098	1.098	0.000 ( +0.0% )	21.81	21.42	+1.8%	1.637	1.640
2500.331	1.393	1.393	0.000 ( +0.0% )	16.14	15.85	+1.9%	1.791	1.786
2500.332	1.324	1.324	0.000 ( +0.0% )	18.28	17.73	+3.1%	1.849	1.848
2500.401	2.138	2.138	0.000 ( +0.0% )	10.46	10.42	+0.4%	1.137	1.192
2500.501	1.711	1.711	0.000 ( +0.0% )	16.25	16.72	-2.8%	1.060	1.119
2500.511	1.123	1.123	0.000 ( +0.0% )	30.78	29.14	+5.6%	1.311	1.369
2500.601	2.050	2.050	0.000 ( +0.0% )	12.22	12.46	-2.0%	1.120	1.172

swertz · 2023-02-08T08:42:31Z

+1

No differences seen, as expected.

mandrenguyen · 2023-02-09T17:59:31Z

+1
xpog business

cmsbuild · 2023-02-09T17:59:58Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-02-10T06:40:51Z

+1

…GLTagger [QGL, JMENanoAOD] Backport of #40667 (PUPPI-compatible QGTagger producer) to 12_6_X

nurfikri89 added 3 commits February 1, 2023 18:17

Modify to use constituent weights from ValueMap. Add option to comput…

0c6c0f5

…e likelihood

Update QGTagger for puppi jets. Add missing pfDeepCSVJetTags:probudsg…

7a25f61

… score for training to fix bug for btagDeepCvL. Fix isPUPPIJet bug for PileUpJetID. Fix name for ParticleNet gluon score.

Fine-tune nanojmeDQM

52baa77

cmsbuild added this to the CMSSW_13_0_X milestone Feb 2, 2023

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Feb 2, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 2, 2023

Apply patches for code-checks and code-format

deb78e8

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 2, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 2, 2023

cmsbuild added tests-started and removed tests-pending labels Feb 2, 2023

cmsbuild added tests-rejected and removed tests-started labels Feb 2, 2023

Add ValueMap header file

305c33e

cmsbuild removed tests-rejected code-checks-approved labels Feb 2, 2023

cmsbuild added tests-started and removed tests-pending labels Feb 7, 2023

cmsbuild added tests-approved and removed tests-started labels Feb 7, 2023

cmsbuild added xpog-approved and removed xpog-pending labels Feb 8, 2023

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Feb 9, 2023

cmsbuild added orp-approved and removed orp-pending labels Feb 10, 2023

cmsbuild merged commit f2c29ef into cms-sw:master Feb 10, 2023

nurfikri89 mentioned this pull request Feb 10, 2023

[QGL, JMENanoAOD] Backport of #40667 (PUPPI-compatible QGTagger producer) to 12_6_X #40740

Merged

jshin96 mentioned this pull request Feb 14, 2023

[PileupJetId, Puppi] Pileup ID input variable fix, puppi weight ValueMap access, optional photon protection for existing puppi weights #40762

Merged

cmsbuild added a commit that referenced this pull request Feb 14, 2023

Merge pull request #40740 from nurfikri89/portFrom130XTo126X_PuppiInQ…

00a0c00

…GLTagger [QGL, JMENanoAOD] Backport of #40667 (PUPPI-compatible QGTagger producer) to 12_6_X

nurfikri89 deleted the from1300pre3_PuppiInQGLTagger branch June 7, 2023 18:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QGL, JMENanoAOD] PUPPI-compatible QGTagger producer #40667

[QGL, JMENanoAOD] PUPPI-compatible QGTagger producer #40667

nurfikri89 commented Feb 2, 2023

cmsbuild commented Feb 2, 2023

cmsbuild commented Feb 2, 2023

cmsbuild commented Feb 2, 2023

swertz commented Feb 2, 2023

swertz commented Feb 2, 2023

cmsbuild commented Feb 2, 2023

swertz commented Feb 7, 2023

cmsbuild commented Feb 7, 2023

swertz commented Feb 8, 2023

mandrenguyen commented Feb 9, 2023

cmsbuild commented Feb 9, 2023

perrotta commented Feb 10, 2023

[QGL, JMENanoAOD] PUPPI-compatible QGTagger producer #40667

[QGL, JMENanoAOD] PUPPI-compatible QGTagger producer #40667

Conversation

nurfikri89 commented Feb 2, 2023

PR description:

PR validation:

cmsbuild commented Feb 2, 2023

cmsbuild commented Feb 2, 2023

cmsbuild commented Feb 2, 2023

swertz commented Feb 2, 2023

swertz commented Feb 2, 2023

cmsbuild commented Feb 2, 2023

Comparison Summary

NANO Comparison Summary

swertz commented Feb 7, 2023

cmsbuild commented Feb 7, 2023

Comparison Summary

NANO Comparison Summary

swertz commented Feb 8, 2023

mandrenguyen commented Feb 9, 2023

cmsbuild commented Feb 9, 2023

perrotta commented Feb 10, 2023