Code to process phase2 version of deepTauID v2p5

[mbluj]

PR description:

This PR adds code for a phase-2 version of DeepTau discriminator. The network structure is identical to that of Run-2/3 DeepTau v2p5, therefore code modifications are small. The changes include:

• Adding scaling parameters and working points for the new training;
• A new "year" identifier introduced to separate this new phase-2 training and current Run-2/3 v2p5 (2026 vs 2018)
• The electron input collection used for the new phase2 deepTauID is sum of two collections: slimmedElectrons (gsfElectrons in EB) and slimmedElectronsHGC (HGCal electrons in endcaps). Notes: 1. The latter collection is called slimmedElectronsFromMultiCl in older CMSSW (<13_0) release series (and samples produced with them) which can cause some problems with running on old samples; 2. The same merged electron collection is used by old-style anti-electron tau discriminant for phase-2;
• The new deepTauID replaces old-style BDT-based tauIDs in miniAOD.

The performance of this phase 2 DeepTau discriminator is documented in AN-22-090.

The PR to cms-data with the data-model is here: cms-data/RecoTauTag-TrainingFiles#11

Backport of the PRs to 12_5/12_6 is foreseen.

To run standalone test, one can run the configuration file RecoTauTag/RecoTau/test/runDeepTauIDsOnMiniAOD.py after setting the flag phase2 = True in that file.

PR validation:

Validated with the standalone test mentioned above and with miniAOD workflows, matrix tests, runTheMatrix.py -l limited -i all --ibeos, successful.
Note: the tests should be run with data-model here: cms-data/RecoTauTag-TrainingFiles#11

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40622/33897

• This PR adds an extra 68KB to repository

• Found files with invalid states:

  • RecoTauTag/RecoTau/test/runDeepTauIDsOnMiniAOD_Phase2.py:
    • Added: cabcb37
    • Deleted: e5c701a

[cmsbuild]

A new Pull Request was created by @mbluj for master.

It involves the following packages:

• PhysicsTools/PatAlgos (xpog, reconstruction)
• RecoTauTag/RecoTau (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @mbluj, @demuller, @seemasharmafnal, @mmarionncern, @missirol, @ahinzmann, @jdolen, @azotz, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @AlexDeMoor, @AnnikaStein, @JyothsnaKomaragiri, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mbluj]

Hello,
this PR must have been overlooked, can someone trigger tests, please?

[swertz]

please test with cms-data/RecoTauTag-TrainingFiles#11

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b4ecf/30241/summary.html
COMMIT: 755c32a
CMSSW: CMSSW_13_0_X_2023-01-29-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40622/30241/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw [Buildrules] Treat ROCM_CXXFLAGS/LDFLAGS as valid compiler flags cmsdist#8271
• @cms-sw [buildrules] disable USE_CMS_DEPRECATED only for cmssw 12 and below cmsdist#8270

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b4ecf/30241/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b4ecf/30241/git-merge-result

Comparison Summary

Summary:

• You potentially removed 2097 lines from the logs
• Reco comparison results: 76 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555495
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555473
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mbluj]

All automated tests seem be OK. Is there anything we can do to help with review of this PR?

[swertz]

+xpog

Expected changes in tauID products for Phase2 MINIAODs.

Thanks for the reminder @mbluj

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[mbluj]

Just a reminder: this PR requires that also data-model PR cms-data/RecoTauTag-TrainingFiles#11 is merged and then propagated to cms-dist.