Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a seemingly useless vector definition #40579

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

perrotta
Copy link
Contributor

PR description:

The removed line in classes.h seems useless to me, but perhaps @lgray remembers why it wass added in #36037

PR validation:

Scram build gives no error

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40579/33826

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta (Andrea Perrotta) for master.

It involves the following packages:

  • DataFormats/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

enable nano

@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cd85a/30095/summary.html
COMMIT: 9316042
CMSSW: CMSSW_13_0_X_2023-01-20-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40579/30095/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555479
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555454
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 10813
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 10813
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.229 2.229 0.000 ( +0.0% ) 9.56 9.60 -0.4% 1.480 1.501
2500.311 2.319 2.319 0.000 ( +0.0% ) 9.21 9.19 +0.1% 1.846 1.847
2500.312 2.273 2.273 0.000 ( +0.0% ) 9.30 9.38 -0.8% 1.862 1.831
2500.33 1.095 1.095 0.000 ( +0.0% ) 22.01 22.06 -0.2% 1.644 1.644
2500.331 1.390 1.390 0.000 ( +0.0% ) 16.25 15.98 +1.7% 1.789 1.792
2500.332 1.321 1.321 0.000 ( +0.0% ) 18.17 18.05 +0.6% 1.848 1.849
2500.401 2.135 2.135 0.000 ( +0.0% ) 10.50 10.28 +2.1% 1.175 1.167
2500.501 1.708 1.708 0.000 ( +0.0% ) 16.77 16.81 -0.2% 1.093 1.082
2500.511 1.120 1.120 0.000 ( +0.0% ) 31.27 30.56 +2.3% 1.358 1.358
2500.601 2.048 2.048 0.000 ( +0.0% ) 12.57 12.54 +0.2% 1.147 1.141

@swertz
Copy link
Contributor

swertz commented Jan 24, 2023

+1

(though I'd also be interested to hear from @lgray )

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor Author

+1

@cmsbuild cmsbuild merged commit b7c7bbb into cms-sw:master Jan 24, 2023
@perrotta perrotta deleted the uselessLineInClassesH branch January 24, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants