-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a seemingly useless vector definition #40579
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40579/33826
|
A new Pull Request was created by @perrotta (Andrea Perrotta) for master. It involves the following packages:
@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
enable nano |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cd85a/30095/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 (though I'd also be interested to hear from @lgray ) |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The removed line in classes.h seems useless to me, but perhaps @lgray remembers why it wass added in #36037
PR validation:
Scram build gives no error