[ROOT6] Fix int type in NanoAD plugins for ROOT6 IB

[aandvalenzuela]

Hello,

Last ROOT6 IB was failing at compilation after the merge of #40478. The issue was not catch during the PR testing since the file where this error happens (PhysicsTools/NanoAOD/plugins/TableOutputFields.cc) is only part of ROOT6 branch.

This PR is to propose a solution by changing the type to Int32. As for the testing, I have created a development area with the latest ROOT6 IB to then apply these changes on top, and the module PhysicsTools/NanoAOD builds fine.
Thanks,

Andrea.

[cmsbuild]

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for CMSSW_13_0_ROOT6_X.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[swertz]

please test

[perrotta]

type bug-fix

[perrotta]

Thank you @aandvalenzuela !
Out of curiosity: can someone explain me why this code is only present in the ROOT6 branch?

[smuzaffar]

@perrotta , see #33825

[davidlange6]

That was 18 months ago... Is still valid? On Jan 17, 2023 4:00 PM, Malik Shahzad Muzaffar ***@***.***> wrote: @perrotta<https://github.com/perrotta> , see #33825<#33825> — Reply to this email directly, view it on GitHub<#40545 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ7I4PTZZDN4VPYXZ5TWSZYAVANCNFSM6AAAAAAT5UNQMY>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[smuzaffar]

yes @davidlange6 , these changes are still only in ROOT6 cmssw branch. I have opened #40547 to backport those to cmssw master

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afd364/30028/summary.html
COMMIT: 9524559
CMSSW: CMSSW_13_0_ROOT6_X_2023-01-16-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40545/30028/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555538
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555513
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[swertz]

+1

AFAIK there is no test of the RNTuple output module, because of some still missing feature (backfilling). But the fix makes sense given the changes introduced in #40478

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_ROOT6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1