-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CPU service calls to ResourceInformationService for non-Intel CPUs #40441
Update CPU service calls to ResourceInformationService for non-Intel CPUs #40441
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40441/33588
|
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Thanks Dan, this was an oversight (of me) in review of #37831. Would it be feasible to resolve the duplication already now? I'm thinking something like changing the |
@makortel that looks cleaner than what I was thinking of, will update the PR |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40441/33593
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40441/33594
|
Pull request #40441 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again. |
PR updated, PR description updated, and since this is now more than a minimal update, made some other gratuitous cleanups of whatever caught my eye. Should be more maintainable now. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40441/33622
|
Pull request #40441 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again. |
@cmsbuild, please test |
@cmsbuild, please test for el8_aarch64_gcc11 |
@cmsbuild, please test for el8_ppc64le_gcc11 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d764d/29857/summary.html |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d764d/29856/summary.html Comparison SummarySummary:
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d764d/29857/summary.html |
+1 Comparison differences are in 11634.7 (#39803) |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The changes made to the CPU service in #37831 to fill the ResourceInformationService CPU models list fails on non-Intel CPUs where "model name" doesn't appear in
/proc/cpuinfo
. This PR integrates the fallback to the cpufeatures library in a more transparent way that fixes the immediate problem and should reduce the possibility of future issues.Fixes TestResourceInformationService unit test failures on non-Intel platforms.
PR validation:
aarch64 output of
FWCore/Services/test/test_resourceInformationService_cfg.py
before:After: