Run3-hcx337 Fix a bug for wrong DetID assignment in HCAL - relevenat for Runs 1,2,3,4

[bsunanda]

PR description:

Fix a bug for wrong DetID assignment in HCAL - relevenat for Runs 1,2,3,4

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for

Need to be back ported to all earlier CMSSW versions

[bsunanda]

type bugfix

[bsunanda]

type urgent

[bsunanda]

@cmsbuild please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39967/32898

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39967/32898/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39967/32898/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39967/32900

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39967/32900/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39967/32900/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39967/32901

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Geometry/HcalCommonData (geometry)
• SimG4CMS/Calo (simulation)

@civanch, @Dr15Jones, @makortel, @ianna, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @thomreis, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[srimanob]

@cmsbuild please test workflow 20834.911

With this PR, the error message of HCAL reported in #37087 for Phase-2 DD4hep is gone. I confirm the test using CMSSW_12_6_0_pre4 with and without this PR. The workflow 20834.911 is used.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61788e/28775/summary.html
COMMIT: cd61a9f
CMSSW: CMSSW_12_6_X_2022-11-03-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39967/28775/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
20834.911 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 46895 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3416398
• DQMHistoTests: Total failures: 137365
• DQMHistoTests: Total nulls: 191
• DQMHistoTests: Total successes: 3278820
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1.5819999999999999 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.352 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): -1.934 KiB SiStrip/MechanicalView
• Checked 208 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: found differences in 14 / 46 workflows

[srimanob]

As PR test shows the error message with Phase-2 DD4hep workflow is gone.

[perrotta]

+1

[mmusich]

Reco comparison results: 46895 differences found in the comparisons

There's a gazillion changes here. Do we understand them?

[bsunanda]

A serious bug in the older version and a fix of that bug in this PR will show zillions of difference showing the earlier bug has serious effect on the outcome of MC predictions

…

________________________________ From: Marco Musich ***@***.*** Sent: 04 November 2022 17:11 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run3-hcx337 Fix a bug for wrong DetID assignment in HCAL - relevenat for Runs 1,2,3,4 (PR #39967) Reco comparison results: 46895 differences found in the comparisons There's a gazillion changes here. Do we understand them? — Reply to this email directly, view it on GitHub<#39967 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOT2HNNN5VOQNQMW2ELWGUYUTANCNFSM6AAAAAARVVY34U>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[makortel]

Does the change impact simulation history?

[bsunanda]

It does not change the history in SIM step but surely changes history in DIGI step due to use of thresholds applying to different channels

…

________________________________ From: Matti Kortelainen ***@***.*** Sent: 04 November 2022 17:36 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run3-hcx337 Fix a bug for wrong DetID assignment in HCAL - relevenat for Runs 1,2,3,4 (PR #39967) Does the change impact simulation history? — Reply to this email directly, view it on GitHub<#39967 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZORLU36IKBUXJ4Z7ZJDWGU3SDANCNFSM6AAAAAARVVY34U>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[makortel]

Thanks @bsunanda. Then large number of differences in small-scale test is expected, right? (and the statistical compatibility can be assessed only with much larger samples)

[abdoulline]

@bsunanda @civanch it looks like there is a change in GEANT history.
Please, find below HCAL (usual private) test w/wo this PR (12_6_X_2022-11-03-2300) with 50 k single pions (e=50 GeV) randomly distributed in eta-phi.
NB:

• GEN (input) is identical in both the cases, so changes come from downstream (SIM, DIGI) modules;
• GT is identical ("phase1_2022_realistic" = '125X_mcRun3_2022_realistic_v3').
  One can see that the first row (SimHits plots) differ.
  https://cms-docs.web.cern.ch/hcal-sw-validation/HcalIdFix/12_6_X_2022-11-03-2300_FIX_run3_vs_12_6_X_2022-11-03-2300_run3_SinglePi/

Otherwise this particular test looks very much similar to other cases (previously considered) when GEANT history is changed.
And it doesn't allow to reveal/prove anything other than the changes could (probably) be rather small.
Well, HCAL RelVal practice/experience shows that regular RelVals with their 9k stat, when used regenerated(new) GENSIM, may not be sensitive to global variables change <1-2% and to binned distributions variation <5-7%, unfortunately.