Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] L1T DQM: Adding the uGT timing sequence back and updating the relevant algo list - backport #39734

Merged

Conversation

vukasinmilosevic
Copy link
Contributor

L1T DQM update:

Putting the uGT timing sequence back into the workflow
Updating relevant triggers to match the Run 3 menu (L1Menu_Collisions2022_v1_0_1)

Backport of #38840 to be included in the online L1T DQM workflow

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 14, 2022

A new Pull Request was created by @vukasinmilosevic (Vukasin Milosevic) for CMSSW_12_4_X.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23bd9e/28342/summary.html
COMMIT: 56b42f6
CMSSW: CMSSW_12_4_X_2022-10-18-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39734/28342/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3675164
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3675134
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1476.3699999999997 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 147.637 KiB L1T/L1TStage2uGT
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

testing at p5

@emanueleusai
Copy link
Member

+1

  • tested and deployed at p5

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #38840

@perrotta
Copy link
Contributor

@vukasinmilosevic the 12_5_X backport is still missing: please don't forget it!
I'd suggest to hold the merging of this PR until the 12_5_X backport is also made available, in order not to forget it.

@rappoccio
Copy link
Contributor

rappoccio commented Oct 21, 2022

hold

  • Will hold until the 12_5 backport is available, otherwise this looks ready.

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @rappoccio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2022

unhold

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 4, 2022

+1

@cmsbuild cmsbuild merged commit 3f75ec0 into cms-sw:CMSSW_12_4_X Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants