HLT Tau DQM from MiniAOD

[slehti]

PR description:

Adding support for running HLT Tau DQM on MiniAOD (PAT) samples so that a larger set of tau discriminators is available for the reference object selection.

PR validation:

Checked that the reference objects are the same for RECO and MiniAOD input.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39651/32451

• This PR adds an extra 52KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39651/32451/code-checks.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39651/32451/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39651/32452

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @slehti for master.

It involves the following packages:

• DQMOffline/Trigger (dqm)
• HLTriggerOffline/Tau (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[emanueleusai]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-863b3b/28095/summary.html
COMMIT: 9fbf715
CMSSW: CMSSW_12_6_X_2022-10-06-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39651/28095/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 11634.0

----- Begin Fatal Exception 07-Oct-2022 10:07:20 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=HLTTauRefProducer label='TauRelvalRefProducer'
Exception Message:
MissingParameter: The required ParameterSet 'Taus' was not specified.
----- End Fatal Exception -------------------------------------------------

• 11634.7

----- Begin Fatal Exception 07-Oct-2022 10:07:34 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=HLTTauRefProducer label='TauRelvalRefProducer'
Exception Message:
MissingParameter: The required ParameterSet 'Taus' was not specified.
----- End Fatal Exception -------------------------------------------------

• 11634.914

----- Begin Fatal Exception 07-Oct-2022 10:08:02 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=HLTTauRefProducer label='TauRelvalRefProducer'
Exception Message:
MissingParameter: The required ParameterSet 'Taus' was not specified.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 11634.911
• 12434.0
• 11834.0

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39651/32480

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #39651 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-863b3b/28164/summary.html
COMMIT: 9e3438c
CMSSW: CMSSW_12_6_X_2022-10-10-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39651/28164/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /pool/condor/dir_35162/jenkins/workspace/compare-root-files-short-matrix/data/PR-863b3b/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3392309
• DQMHistoTests: Total failures: 90
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3392197
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 49 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

@slehti there's several differences in the DQM plots in JetMET/METValidation and JetValidation that do not seem compatible with the description of the PR. Do you understand where those differences are coming from?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_6_X_2022-10-10-2300+863b3b/53314/39500.0_CloseByPGun_CE_H_Coarse_Scint+2026D88+CE_H_Coarse_Scint_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal/JetMET_JetValidation_ak4PFJets.html

[makortel]

there's several differences in the DQM plots in JetMET/METValidation and JetValidation that do not seem compatible with the description of the PR. Do you understand where those differences are coming from?

Unexpected differences in JetMET/{Jet,MET}Validation in phase2 workflows are seen in some other PRs as well, see issue #39754.

[slehti]

The HLT Tau DQM should not affect JetMET/METValidation and JetValidation in any way. Changes if any should only be in the HLT Tau DQM plots.
I do not understand those differences, and the PR is not touching JetMET/METValidation or JetValidation code.