-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SiStrip and SiPixel bad components for Run 3 MC GTs #39645
Update SiStrip and SiPixel bad components for Run 3 MC GTs #39645
Conversation
type trk |
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39645/32448
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1138a5/28053/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
I'm not sure I understand why the MET is affected I can understand the changes in the EGM conversion plots, PF too, the digitizer based changes as well. But does it really propagate upto the MET level? |
Unexpected differences in |
@cms-sw/alca-l2 what's preventing merge of this PR? |
Yes absolutely. Given Matti's comment (#39645 (comment)) it seems the JetMet differences are not coming from this PR. But tests are 12 days old...we should probably refresh them (I cannot see the differences anymore)? |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1138a5/28326/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR updates, in the Run 3 realistic MC GTs, the SiPixel (CMSTalk request) and SiStrip (CMSTalk request) bad components tags.
The tags updated are:
SiStripBadComponents_realisticMC_for2022_v2_mc
SiPixelQuality_phase1_2022_v2_mc
SiPixelQuality_forDigitizer_phase1_2022_v2_mc
with labelforDigitizer
SiPixelQuality_phase1_2022_forRawToDigi_v0
with labelforRawToDigi
SiPixelQuality_phase1_2023_v2_mc
SiPixelQuality_forDigitizer_phase1_2023_v2_mc
with labelforDigitizer
SiPixelQuality_phase1_2024_v2_mc
SiPixelQuality_forDigitizer_phase1_2024_v2_mc
with labelforDigitizer
GT diffs:
2022 realistic: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_mcRun3_2022_realistic_v3/125X_mcRun3_2022_realistic_v4
2022 cosmics design: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_mcRun3_2022cosmics_realistic_deco_v3/125X_mcRun3_2022cosmics_realistic_deco_v4
2022 heavy ion: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_mcRun3_2022_realistic_HI_v3/125X_mcRun3_2022_realistic_HI_v4
2023 realistic: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_mcRun3_2023_realistic_v3/125X_mcRun3_2023_realistic_v4
2024 realistic: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/125X_mcRun3_2024_realistic_v3/125X_mcRun3_2024_realistic_v4
PR validation:
Tested with:
runTheMatrix.py -l 11634.0,7.23,159.0,12434.0,12834.0 --ibeos -j 16
Backport:
Not a backport, but a 12_5_X backport will be opened soon.